integration: Fixes deadlock in 'go test -tags cluster_proxy -v ./integration/... ./clientv3/...' #12319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptabor
force-pushed
the
20200920-proxy-test-ctx
branch
from
193f45f to
3419a2a
Compare
ptabor
force-pushed
the
20200920-proxy-test-ctx
branch
2 times, most recently
from
f3938f3 to
68cf59c
Compare
ptabor
force-pushed
the
20200920-proxy-test-ctx
branch
from
68cf59c to
33b26b0
Compare
xiang90
reviewed
Sep 25, 2020
|
lgtm after fixing the nit. |
ptabor
force-pushed
the
20200920-proxy-test-ctx
branch
2 times, most recently
from
cdb4705 to
90c1559
Compare
…ntv3/...' passes now. The grpc-proxy test logic was assuming that the context associated to client is closed, while in practice all tests called client.Close() without explicit context close. The current testing strategy is complicated 2 fold: - grpc proxy works like man-in-the middle of each Connection issues from integration tests and its lifetime is bound to the connection. - both connections (client -> proxy, and proxy -> etcd-server) are represented by the same ClientV3 object instance (with substituted implementations of KV or watcher). The fix splits context representing proxy from context representing proxy -> etcd-server connection, thus allowing cancelation of the proxy context.
ptabor
force-pushed
the
20200920-proxy-test-ctx
branch
from
90c1559 to
4676af6
Compare
|
Thank you for review ! |
ahrtr
added a commit
to ahrtr/etcd
that referenced
this pull request
Jun 28, 2022
…lientv3/...' Cherry pick etcd-io#12319 to 3.4. Signed-off-by: Benjamin Wang <[email protected]>
tjungblu
pushed a commit
to tjungblu/etcd
that referenced
this pull request
Sep 8, 2022
…lientv3/...' Cherry pick etcd-io#12319 to 3.4. Signed-off-by: Benjamin Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grpc-proxy test logic was assuming that the context associated to client is closed,
while in practice all tests called client.Close() without explicit context close.
The current testing strategy is complicated 2 fold:
from integration tests and its lifetime is bound to the connection.
represented by the same ClientV3 object instance (with substituted
implementations of KV or watcher).
The fix splits context representing proxy from context representing proxy -> etcd-server connection,
thus allowing cancelation of the proxy context.