-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: gRPC gateway not support cancel-request
#12333
Comments
I tried to directly close the http connection that |
I think I've seen it in integration tests as well. I suspect it might be related to this comment: Line 72 in add86bb
Proxy cannot close underlying watch request to etcd-server without closing the whole underlying connection, so it also does not support it on its surface. |
It's so great you're working on it! Hope this problem could get fixed soon. |
I must have been not precise: I find it important, but I don't claim ownership of this problem (yet). |
No problem I mean it would be better if it could get fixed, but we'll also try to fix it on our side since it is confirmed the etcd native way is not supported for now so we need to find our own way to deal with it. Anyway thank you for your explanation! |
fixed on our side |
Hi community,
I'm developing etcd client for lua/openresty, and since it does not support grpc, we're using grpc gateway to use RESTful API. I know it would be hard to reproduce the problem, since it's in another language, but I try to make myself clear.
create_request
orprogress_request
, there would be normal responce.But when I set body to
cancel_request
, the request would always returntimeout
, the same when I set body tofoo_request
. So I guesscancel_request
might not be supported in gRPC gateway.Also I tried to find other etcd client in non-grpc-supported language, but it seems none of them support this feature that cancel the watch. I would be also grateful if there are some reference to implement this feature.
The text was updated successfully, but these errors were encountered: