Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing CI #3676

Merged
merged 4 commits into from
Apr 21, 2020
Merged

Fix failing CI #3676

merged 4 commits into from
Apr 21, 2020

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented Apr 21, 2020

Description of changes:

jngrad added 3 commits April 21, 2020 13:45
Check `mesh` against int instead of basestring and delegate array
validation to the check_type_or_throw_except() helper function.
@jngrad jngrad added this to the Espresso 4.1.3 milestone Apr 21, 2020
fweik
fweik previously approved these changes Apr 21, 2020
@fweik
Copy link
Contributor

fweik commented Apr 21, 2020

That is a lot of issues!

@fweik fweik added the automerge Merge with kodiak label Apr 21, 2020
@jngrad jngrad removed the automerge Merge with kodiak label Apr 21, 2020
@jngrad
Copy link
Member Author

jngrad commented Apr 21, 2020

we don't know yet if it works, and one commit needs to be removed

@fweik
Copy link
Contributor

fweik commented Apr 21, 2020

It won't merge until you remove draft...

@jngrad jngrad marked this pull request as ready for review April 21, 2020 12:31
@fweik
Copy link
Contributor

fweik commented Apr 21, 2020

Ah, but the review is dismissed :-)

@KaiSzuttor

This comment has been minimized.

fweik
fweik previously approved these changes Apr 21, 2020
@fweik fweik added the automerge Merge with kodiak label Apr 21, 2020
@codecov
Copy link

codecov bot commented Apr 21, 2020

Codecov Report

Merging #3676 into python will decrease coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           python   #3676    +/-   ##
=======================================
- Coverage      87%     87%    -1%     
=======================================
  Files         536     526    -10     
  Lines       22756   21987   -769     
=======================================
- Hits        20014   19297   -717     
+ Misses       2742    2690    -52     
Impacted Files Coverage Δ
...rialization/ibm_cuda_particle_velocities_input.hpp 0% <0%> (-100%) ⬇️
...al_sites/lb_inertialess_tracers_cuda_interface.cpp 0% <0%> (-100%) ⬇️
src/core/actor/ActorList.cpp 0% <0%> (-80%) ⬇️
src/core/EspressoSystemInterface.cpp 40% <0%> (-51%) ⬇️
...tatics_magnetostatics/magnetic_non_p3m_methods.cpp 0% <0%> (-32%) ⬇️
...rc/core/grid_based_algorithms/lb_interpolation.cpp 85% <0%> (-10%) ⬇️
src/core/electrostatics_magnetostatics/dipole.cpp 58% <0%> (-8%) ⬇️
src/core/forces.cpp 96% <0%> (-4%) ⬇️
src/core/energy.cpp 95% <0%> (-3%) ⬇️
src/core/grid_based_algorithms/lb_interface.cpp 68% <0%> (-2%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c403abc...c69281c. Read the comment docs.

@kodiakhq kodiakhq bot merged commit 9d5c510 into espressomd:python Apr 21, 2020
@jngrad jngrad deleted the fix-3671 branch January 18, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants