-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing CI #3676
Fix failing CI #3676
Conversation
Check `mesh` against int instead of basestring and delegate array validation to the check_type_or_throw_except() helper function.
That is a lot of issues! |
we don't know yet if it works, and one commit needs to be removed |
It won't merge until you remove draft... |
Ah, but the review is dismissed :-) |
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## python #3676 +/- ##
=======================================
- Coverage 87% 87% -1%
=======================================
Files 536 526 -10
Lines 22756 21987 -769
=======================================
- Hits 20014 19297 -717
+ Misses 2742 2690 -52
Continue to review full report at Codecov.
|
Description of changes:
lb_profile
(fixes Add GPU fixture in lb_profile sample test #3671, closes CI build failed for merged PR #3669, closes CI build failed for merged PR #3670, closes CI build failed for merged PR #3674)mesh
checks in P3M methods