Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GPU fixture in lb_profile sample test #3671

Closed
espresso-ci opened this issue Apr 20, 2020 · 8 comments · Fixed by #3676
Closed

Add GPU fixture in lb_profile sample test #3671

espresso-ci opened this issue Apr 20, 2020 · 8 comments · Fixed by #3676
Assignees
@jngrad
Milestone
Espresso 4.1.3

Comments

@espresso-ci
Copy link

https://gitlab.icp.uni-stuttgart.de/espressomd/espresso/pipelines/11802
@fweik
Copy link
Contributor

fweik commented Apr 20, 2020

The failure in sample_lb_profile is new and recurring, this should be investigated.

@fweik
Copy link
Contributor

fweik commented Apr 20, 2020

@KaiSzuttor can you please look at this?

@KaiSzuttor
Copy link
Member

don't know... recent changes have been made by @jngrad and @RudolfWeeber . Tested the sample 50+ times on my machine without failure.

@fweik
Copy link
Contributor

fweik commented Apr 20, 2020

Then check if you can reproduce it in the runners/containers? In the CI it seems pretty consistent...

@KaiSzuttor
Copy link
Member

works on my machine within the container

@jngrad jngrad assigned jngrad and unassigned KaiSzuttor Apr 21, 2020
@jngrad
Copy link
Member

jngrad commented Apr 21, 2020

Found the source of the issue, I forgot to add a GPU fixture in the new lb_profile test, sorry for the trouble. PR is coming.

@jngrad jngrad changed the title CI build failed for merged PR Add GPU fixture in lb_profile sample test Apr 21, 2020
@jngrad jngrad added this to the Espresso 4.1.3 milestone Apr 21, 2020
@KaiSzuttor
Copy link
Member

the real issue is the cryptic error message

@fweik
Copy link
Contributor

fweik commented Apr 21, 2020

@KaiSzuttor can you please open a separate ticket for that?

@jngrad jngrad mentioned this issue Apr 21, 2020
Merged
@kodiakhq kodiakhq bot closed this as completed in #3676 Apr 21, 2020
kodiakhq bot added a commit that referenced this issue Apr 21, 2020
@kodiakhq
Fix failing CI (#3676)
9d5c510 
Description of changes:
- add GPU fixture in `lb_profile` (fixes #3671, closes #3669, closes #3670, closes #3674)
- fix incorrect `mesh` checks in P3M methods
- post the style patch (fixes #3672)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jngrad jngrad

Labels
None yet
Projects
None yet
Milestone
Espresso 4.1.3
Development

Successfully merging a pull request may close this issue.

Fix failing CI jngrad/espresso
4 participants
@fweik @KaiSzuttor @espresso-ci @jngrad