Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenGL.GL missing before GL_DEPTH_ATTACHEMENT #2945

Merged
merged 1 commit into from
Jun 26, 2019

Conversation

Raketenjoint
Copy link

Fixes #2295
Crash when making screenshots with module espressomd.visualization_opengl:

Traceback (most recent call last):
  File "EOF.py", line 68, in <module>
    visualizer.screenshot()
  File "visualization_opengl.pyx", line 522, in espressomd.visualization_opengl.openGLLive.screenshot
NameError: name 'GL_DEPTH_ATTACHMENT' is not defined

Description of changes:

  • Added OpenGL.GL. in front of GL_DEPTH_ATTACHEMENT

PR Checklist

  • Tests: made Screenshots
    • Interface
    • Core
  • Docs?

@codecov
Copy link

codecov bot commented Jun 26, 2019

Codecov Report

Merging #2945 into python will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           python   #2945   +/-   ##
======================================
  Coverage      83%     83%           
======================================
  Files         520     520           
  Lines       26745   26745           
======================================
  Hits        22335   22335           
  Misses       4410    4410

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c59817...c4acd39. Read the comment docs.

@KaiSzuttor
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Jun 26, 2019
2945: OpenGL.GL missing before GL_DEPTH_ATTACHEMENT r=KaiSzuttor a=Raketenjoint

Fixes #2295
Crash when making screenshots with module `espressomd.visualization_opengl`:
```
Traceback (most recent call last):
  File "EOF.py", line 68, in <module>
    visualizer.screenshot()
  File "visualization_opengl.pyx", line 522, in espressomd.visualization_opengl.openGLLive.screenshot
NameError: name 'GL_DEPTH_ATTACHMENT' is not defined
```
Description of changes:
 - Added `OpenGL.GL.` in front of `GL_DEPTH_ATTACHEMENT`

PR Checklist
------------
 - [x] Tests: made Screenshots
   - [ ] Interface
   - [ ] Core 
 - [ ] Docs?


Co-authored-by: Tim Meiler <[email protected]>
@jngrad
Copy link
Member

jngrad commented Jun 26, 2019

@KaiSzuttor I could reproduce the error and this PR fixes it. However when I run

visualizer.screenshot('image.png')
visualizer.run(1)

The visualizer freezes. If I click inside the window, the visualization resumes, an exception is caught and its traceback is printed to stdout, but the script doesn't crash. Is this the expected behavior? When I do regular screenshots with the Enter key (in a script without any call to visualizer.screenshot()) , there is no such exception.

@KaiSzuttor
Copy link
Member

I have not looked into the other issue you mentioned but this PR at least corrects for the missing module name in front of the variable

@bors
Copy link
Contributor

bors bot commented Jun 26, 2019

Build succeeded

@bors bors bot merged commit c4acd39 into espressomd:python Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants