Opengl wildcard imports + mac fix (@konradbreitsprecher) #2295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
KaiSzuttor
commented
Oct 5, 2018
•
KaiSzuttor
commented
- speeds up importing the visualization module by approx a factor of 10
Codecov Report
@@ Coverage Diff @@
## python #2295 +/- ##
=======================================
+ Coverage 71% 71% +<1%
=======================================
Files 380 380
Lines 18938 18938
=======================================
+ Hits 13586 13588 +2
+ Misses 5352 5350 -2
Continue to review full report at Codecov.
|
KaiSzuttor
changed the title
fweik
approved these changes
Oct 5, 2018
RudolfWeeber
pushed a commit
to RudolfWeeber/espresso
that referenced
this pull request
Oct 15, 2018
Opengl wildcard imports + mac fix (@KonradBreitsprecher)
4 tasks
bors bot
added a commit
that referenced
this pull request
Jun 26, 2019
2945: OpenGL.GL missing before GL_DEPTH_ATTACHEMENT r=KaiSzuttor a=Raketenjoint Fixes #2295 Crash when making screenshots with module `espressomd.visualization_opengl`: ``` Traceback (most recent call last): File "EOF.py", line 68, in <module> visualizer.screenshot() File "visualization_opengl.pyx", line 522, in espressomd.visualization_opengl.openGLLive.screenshot NameError: name 'GL_DEPTH_ATTACHMENT' is not defined ``` Description of changes: - Added `OpenGL.GL.` in front of `GL_DEPTH_ATTACHEMENT` PR Checklist ------------ - [x] Tests: made Screenshots - [ ] Interface - [ ] Core - [ ] Docs? Co-authored-by: Tim Meiler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.