consistent style in samples #1845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## python #1845 +/- ##
=======================================
+ Coverage 60% 60% +<1%
=======================================
Files 422 422
Lines 29269 29269
=======================================
+ Hits 17835 17836 +1
+ Misses 11434 11433 -1
Continue to review full report at Codecov.
|
jonaslandsgesell
approved these changes
Feb 13, 2018
pkreissl
approved these changes
Feb 13, 2018
Closed
ashreyaj
pushed a commit
to ashreyaj/espresso
that referenced
this pull request
Aug 9, 2018
consistent style in samples
jngrad
added a commit
to jngrad/espresso
that referenced
this pull request
Jan 14, 2019
+ Change instructions "from XYZ import *" to "import XYZ" + Use module argparse for complex command line interfaces + Format messages with str.format() + Use modern Python2.7 syntax + Remove irrelevant/legacy code + Wrap long docstrings and multi-line strings + Move docstrings under the copyright header + Give pickle files the .pkl extension
jngrad
added a commit
to jngrad/espresso
that referenced
this pull request
Jan 15, 2019
- Change instructions "from XYZ import *" to "import XYZ" - Use argparse for complex command line interfaces - Format messages with str.format() - Use modern Python2.7 syntax - Remove irrelevant/legacy code - Wrap long strings into multi-line strings - Move docstrings under the copyright header - Give pickle files the .pkl extension
jngrad
added a commit
to jngrad/espresso
that referenced
this pull request
Jan 16, 2019
- Change instructions "from XYZ import *" to "import XYZ" - Use argparse for complex command line interfaces - Format messages with str.format() - Use modern Python2.7 syntax - Remove irrelevant/legacy code - Wrap long strings into multi-line strings - Move docstrings under the copyright header - Give pickle files the .pkl extension
kodiakhq bot
added a commit
that referenced
this pull request
Feb 25, 2020
Description of changes: - `lb.rst` contained outdated code for instantiating the `System`-class, namely missing the mandatory `box_l` parameter, only trying to set it afterwards. - Fixed that there and in all other places that I found via a quick search. - While at it, I renamed the occurrences of instances of `System` that were not called `system`, to match the naming convention of #1845.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
changed samples such they all have the same style, so that users could copy/paste code blocks from different samples into their own.
for example, all sampls now have
system=espresomd.System()
instead of sys=espresomd.System() or S=espresomd.System()
all concerned scripts now also use
import numpy as np
Description of changes:
PR Checklist