-
Notifications
You must be signed in to change notification settings - Fork 188
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
3107: Fix failing grand_canonical sample test and add documentation to samples r=jngrad a=jonaslandsgesell This PR adds documentation in to the sample files: * widom_insertion.py * wang_landau_reaction_ensemble.py * grand_canonical.py * reaction_ensemble.py The PR also fixes partly #3104: The problem with the failing test was that the excess chemical potential did not match the submitted concentration. I now provide a matching pair of concentration and excess chemical potential. Co-authored-by: Jonas Landsgesell <[email protected]> Co-authored-by: Jean-Noël Grad <[email protected]>
- Loading branch information
Showing
8 changed files
with
284 additions
and
270 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.