-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes HW Serial attaching pins, PHY initialization, crash after end() #9365
Conversation
Fixes HW Serial pin setup. The pins were set up to the wrong value and it could not be correctly configured and used.
Fixes the PHY initialization. After detaching the pin and ending the HW Serial, a new begin() wouldn't start the CDC because it lacked the proper PHY initialization.
Fixes a crash when calling end() end() treminanates the `tx_ring_buf` but it was not tested for NULL in the ISR and in the cdc0_write_char() causing a crash if those are used. This depends on events and happens eventually.
👋 Hello SuGlider, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
The roll back re-introduces CI compile errors for the others CDC MCUs |
I decided to set the registers directly for all the SoC. It works fine now. |
issue with `if(Serial)` not working always
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tested with S3 and the issue is gone. Great job :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Tested on C6 👍 |
Description of Change
Fixes:
Tests scenarios
Tested with ESP32-C3, ESP32-S3, ESP32-C6, ESP32-H2
Related links
Fixes #9360