Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HWCDC & periman broken #9360

Closed
1 task done
lbernstone opened this issue Mar 11, 2024 · 4 comments · Fixed by #9365
Closed
1 task done

HWCDC & periman broken #9360

lbernstone opened this issue Mar 11, 2024 · 4 comments · Fixed by #9365
Assignees
Labels
Area: Peripherals API Relates to peripheral's APIs. Status: In Progress Issue is in progress Type: Bug 🐛 All bugs
Milestone

Comments

@lbernstone
Copy link
Contributor

lbernstone commented Mar 11, 2024

Board

esp32-c6

Device Description

devkitc

Hardware Configuration

usb connected (to usb-otg)

Version

latest master (checkout manually)

IDE Name

Arduino

Operating System

linux

Flash frequency

80MHz

PSRAM enabled

yes

Upload speed

usb

Description

#9331 has issues. Please test on a esp32-c3 or c6. Pins do not get set properly. The pin assignments on line 249&258 are wrong, and even if pins are set properly I don't get USB-CDC starting.

Sketch

Any with serial output

Debug Message

none

Other Steps to Reproduce

No response

I have checked existing issues, online documentation and the Troubleshooting Guide

  • I confirm I have checked existing issues, online documentation and Troubleshooting guide.
@lbernstone lbernstone added the Status: Awaiting triage Issue is waiting for triage label Mar 11, 2024
@lucasssvaz lucasssvaz added Area: Peripherals API Relates to peripheral's APIs. and removed Status: Awaiting triage Issue is waiting for triage labels Mar 12, 2024
@lucasssvaz
Copy link
Collaborator

@SuGlider PTAL

@SuGlider
Copy link
Collaborator

@lbernstone - Correct. I'll fix it.

@TD-er
Copy link
Contributor

TD-er commented Mar 12, 2024

Not sure if related, but HWCDC on the ESP32-S3 is also working really bad.
Not as broken as on the C3 (doesn't even show up as serial port anymore in Windows) but it does skip quite a lot of bytes sent to any connected terminal (I use it as console in ESPEasy)
I used to send it per byte from a buffer to the serial port, but I noticed it is now doing quite a lot of locking, so I adapted the code to flush in chunks.
Now it just flushes my chunk of data and then doesn't output anything for quite a while.
Just like the availableForWrite is reporting 0. (have to check to be sure this is causing it)

@SuGlider
Copy link
Collaborator

Not sure if related, but HWCDC on the ESP32-S3 is also working really bad. Not as broken as on the C3 (doesn't even show up as serial port anymore in Windows) but it does skip quite a lot of bytes sent to any connected terminal (I use it as console in ESPEasy) I used to send it per byte from a buffer to the serial port, but I noticed it is now doing quite a lot of locking, so I adapted the code to flush in chunks. Now it just flushes my chunk of data and then doesn't output anything for quite a while. Just like the availableForWrite is reporting 0. (have to check to be sure this is causing it)

@TD-er - please open a new issue reporting this problem with a sketch that I can use to reproduce it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Peripherals API Relates to peripheral's APIs. Status: In Progress Issue is in progress Type: Bug 🐛 All bugs
Projects
Development

Successfully merging a pull request may close this issue.

5 participants