feat(touch): Support NG touch driver for P4 #10448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
P-R-O-C-H-Y
force-pushed
the
feat/touch-v3-support
branch
from
31ffebf
to
030c07e
Compare
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
P-R-O-C-H-Y
force-pushed
the
feat/touch-v3-support
branch
from
3b0e96c
to
da31968
Compare
lucasssvaz
reviewed
Oct 15, 2024
tests/validation/touch/touch.ino
Outdated
There was a problem hiding this comment.
Does this test work properly on your board ? Mine is the older version and it fails 🤔
There was a problem hiding this comment.
On mine P4-EV board v1.4 it worked.
me-no-dev
reviewed
Oct 16, 2024
me-no-dev
approved these changes
Oct 21, 2024
me-no-dev
added
Status: Pending Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR adds support for the new NG Touch Driver, which is currently supports touch V3 (ESP32-P4). There is work in progress for V2 and later for V1 touch versions to be supported by the new touch driver.
The new touch driver is implemented the way, to keep backward compatibility with the old APIs.
To get more features as multiple sampling on different frequencies, we may add/change APIs a bit.
Tests scenarios
Tested locally on P4, also using the touch HW test.
NOTE: Touch deep sleep wakeup is currently not working, fix is needed on driver side. The implementation should be ready.
NOTE 2: Fix is ready and will be merged to IDF master and v5.3 branch.
Related links