Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to configure the device driver IRAM placement (RFC) #1096

Merged
merged 8 commits into from
Feb 21, 2024

Conversation

ProfFan
Copy link
Contributor

@ProfFan ProfFan commented Jan 19, 2024

Per the discussion in #946

@ProfFan ProfFan changed the title Add option to configure the device driver IRAM placement ( Add option to configure the device driver IRAM placement (RFC) Jan 19, 2024
@ProfFan ProfFan force-pushed the spi-timing-fix branch 2 times, most recently from fef48ec to 9fc2c4a Compare January 26, 2024 18:04
@bjoernQ
Copy link
Contributor

bjoernQ commented Jan 29, 2024

Probably related to #1111 - it's probably something we want to configure in a way different from cargo features

@ProfFan ProfFan force-pushed the spi-timing-fix branch 2 times, most recently from 56833aa to cb5f783 Compare January 31, 2024 20:33
@ProfFan ProfFan force-pushed the spi-timing-fix branch 2 times, most recently from fc95a72 to ddcf089 Compare February 16, 2024 19:12
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ProfFan We've decided to accept this PR, in lieu of a configuration-based solution.

Could you remove the unnecessary changes and rebase on main?

esp-hal/src/spi/master.rs Outdated Show resolved Hide resolved
esp-hal/src/spi/master.rs Outdated Show resolved Hide resolved
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just clippy to fix and it looks good to go!

esp-hal/src/spi/master.rs Outdated Show resolved Hide resolved
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MabezDev MabezDev added this pull request to the merge queue Feb 21, 2024
Merged via the queue into esp-rs:main with commit 9a95c0a Feb 21, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants