-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to configure the device driver IRAM placement (RFC) #1096
Conversation
fef48ec
to
9fc2c4a
Compare
Probably related to #1111 - it's probably something we want to configure in a way different from cargo features |
56833aa
to
cb5f783
Compare
fc95a72
to
ddcf089
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ProfFan We've decided to accept this PR, in lieu of a configuration-based solution.
Could you remove the unnecessary changes and rebase on main?
e796169
to
68d1f17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just clippy to fix and it looks good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Per the discussion in #946