ci: Work around npm behavior changes to fix CI on main #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A change between npm 8.9 and 8.10 started running the main package's `prepare` script as part of the examples' installs. This broke CI when the install step launched a fork bomb and got killed after several minutes. This change should fix builds on `main`.
|
Looks like there are two behavior changes in npm since 8.5 that are breaking our CI. I'm not yet confident enough that our usage is intended to be supported to call them regressions or breaking changes, so I'm sticking with behavior changes for now. I have a workaround for the second change that is still causing CI to fail on this branch. (Spoiler alert: peer deps, or course.) I needed to step away for a bit but will push the fix later. |
Something about peer dependencies changed between npm 8.5.5 and 8.6.0 that is causing CI to fail on `main` with ESLint 6 on the test matrix. This works around the issue.
btmills
changed the title
This was referenced Jun 20, 2022
Merged
btmills
commented
Jun 20, 2022
| @@ -82,7 +82,7 @@ describe("recommended config", () => { | |||
| // eslint-disable-next-line no-invalid-this | |||
| this.timeout(30000); | |||
|
|
|||
| execSync("npm link && npm link eslint-plugin-markdown"); | |||
| execSync("npm link && npm link eslint-plugin-markdown --legacy-peer-deps"); | |||
There was a problem hiding this comment.
We have to use --legacy-peer-deps because there is no version of eslint-plugin-jsdoc that supports ESLint 6, 7, and 8. --legacy-peer-deps disables additional peer dependency checks that were added in npm 8.6.0 and caused our CI to begin failing.
nzakas
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits address two behavior changes in npm that changed between Node 16.15.0, which bundles npm 8.5.5, and Node 16.15.1, which bundles npm 8.11.0:
preparescript recursively as part of the examples' sub-installs. This broke CI when the install step launched a fork bomb and got killed after several minutes on recent versions of Node that ship npm >= 8.10.0. I've left a comment on [BUG] npm install on Mac - Out of Memory npm/cli#4895, which appears to be related.These changes should fix builds on
main.