feat!: drop node v8 and v10

[amareshsm]

Description:

Drop node v8.x and v10.x

[nzakas]

@btmills thoughts?

[btmills]

TSC summary: eslint-plugin-markdown currently tests against ESLint 6+ and Node 8+. This pull request would drop support for end-of-life versions of Node.js. Normally, we drop support for EOL engines as part of regular major releases. However, we have no other breaking changes queued up for this package.

TSC question: Should we do a semver-major release just to drop support for EOL Node.js versions?

[btmills]

Thank you, @amareshsm! The team had no objections to doing a v3 with dropping EOL versions as the only breaking change.

It looks like there are some compat issues with Node 18. If necessary, feel free to drop 8/10/<12.22.0 here and split adding 18 support into another PR.

[amareshsm]

Drafted a separate PR for node v18 support.

[btmills]

One inline change, then LGTM!

[amareshsm]

Bump

[btmills]

This and your other PR appear to be failing due to behavior changes in new npm versions that were released since the previous merges to main. Nothing about your change caused these failures. I've submitted #206 to fix the changes on main. Once that's in, I bet rebasing both of your branches will let them pass 👍

[btmills]

Closing and reopening to see if that'll fix CI without having to rebase now that #206 is merged.

[btmills]

That's more like it! Thanks for your patience, @amareshsm. LGTM, but since this is a breaking change, I'll leave it open another couple days to give others a chance to review.

[snitin315]

LGTM. Thanks!

[nzakas]

LGTM