Fix: Fix behavior of ignoring comments within previous nodes (refs #256) #262
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding tests to the main ESLint repo to account for the changes I made in #257 I realized that some of my initial assumptions were wrong:
body
prop is always an array (in reality it can be an array or an object)body
props recursively (I had incorrectly thought theProgram
node'sbody
contained all the nodes, which, in retrospect, is pretty silly)This means that my current merged fix does not account for this case, as the comment to remove is nested a few levels deep, with the
body
props being a mixture of arrays and objects as you drill down:I'm going to test out the main ESLint repo with this branch now, but wanted to see if I could get some eyes on this to see if it made sense. Thanks!