Fix: leading comments added from previous node (fixes #256) #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test for this change? Chances are that there was an error in Mootools output that this fixes. You can run |
|
Yeah, of course! Tests added. Sorry, wasn't understanding how these tests were organized/generated, but I see now. Let me know if I can do anything else! May take a look at #212 after this PR lands, since I've familiarized myself with the code and the change is probably a similar thing :) |
| "raw": "'bar'" | ||
| }, | ||
| "kind": "init", | ||
| "trailingComments": [ |
There was a problem hiding this comment.
Correctly adds trailing comment to bar property
|
Awesome, thank you! |
nzakas
added a commit
that referenced
this pull request
Mar 14, 2016
Fix: leading comments added from previous node (fixes #256)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the
mootoolstest is failing. Not sure if this means my change is bad or the expected output from the test is incorrect now that this change has been made. Are these generated with a command somewhere?I ran this version of my change against the current master branch to test for speed and was surprised to find no conclusive evidence of this slowing things down (most likely because my change only runs on comments and only when the node type is
Program)...Some tests were a bit slower, and others were a bit faster. So doesn't seem like a huge impact on performance 👍