eschweitzer78/issue-280 #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Omnistudio v248 (which is in preview) introduces a breaking change in the template for the combobox widget used in the Select element.
The v246 combobox has an event handler on "
mouseup" whereas the v248 combobox has it on "click". The handler code actively tests the event type so thatmouseupno longer triggers the right business logic in theshowLookupmethod if the running omnistudio version is 248 and we keep a v246 style template.As a fix, we add "
click" as a further trigger for the handler knowing the v246 and v248 will discard the event they are not interested in (mouseupignored in v248,clickignored in v246).What issues does this PR fix or reference?
#280
#
The PR fulfills these requirements:
[ ] Tests for the proposed changes have been added/updated.
[x] Code linting and formatting was performed.
Functionality Before
Omnistudio select does not show options when clicking on the input field.
Functionality After
Options are shown again.