Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sfGpsDsAuNswFormSelectOsN component not working in Spring 24 sandbox #280

Closed
1 task done
rajeshkeswani opened this issue Jan 8, 2024 · 7 comments · Fixed by #281
Closed
1 task done

sfGpsDsAuNswFormSelectOsN component not working in Spring 24 sandbox #280

rajeshkeswani opened this issue Jan 8, 2024 · 7 comments · Fixed by #281
Assignees
Labels
bug Something isn't working

Comments

@rajeshkeswani
Copy link

rajeshkeswani commented Jan 8, 2024

Summary

sfGpsDsAuNswFormSelectOsN component not working in Spring 24 sandbox

Salesforce Org Type

Sandbox

Steps To Reproduce

No response

Current Behavior

No response

Expected Behavior

No response

Relevant Log Output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@rajeshkeswani rajeshkeswani added the bug Something isn't working label Jan 8, 2024
Copy link

github-actions bot commented Jan 8, 2024

Welcome! 👋

Thank you for posting this issue. 🙇🏼‍♂️ We will come back to you latest within the next 48h (working days). Stay tuned!

@rajeshkeswani rajeshkeswani changed the title sfGpsDsAuNswFormSelectOsN component not working in sprint 24 sandbox sfGpsDsAuNswFormSelectOsN component not working in Spring 24 sandbox Jan 8, 2024
@eschweitzer78
Copy link
Owner

eschweitzer78 commented Jan 8, 2024

Hi @rajeshkeswani thank you for your report. I'll have a look as I have a preview sandbox available -- is there any more specific info you can share?

@rajeshkeswani
Copy link
Author

@eschweitzer78 thanks for your prompt reply.
I see dropdown is not coming when clicked on combobox

MicrosoftTeams-image (124)

@eschweitzer78
Copy link
Owner

eschweitzer78 commented Jan 8, 2024

Hi Rajesh, it looks like Omnistudio 248 introduces a breaking change on the combobox class that's used in the Select widget (well, breaking if you do change the HTML template or look at the 246 template):

  • in 248 there is event handling on the input for blur, click, keydown or keyup
  • whereas in 246 it was blur, mouseup, keydown, keyup

As the event handler actively checks the event type, mouseup no longer matches the new requirement for click. I'll modify the template used in the library to add click as well, the excess event should be discarded (click discarded in 246, mouseup discarded in 248).

@eschweitzer78
Copy link
Owner

eschweitzer78 commented Jan 8, 2024

This workaround/fix leads to the right outcome in my preview sandbox, so I'll start a build for that momentarily. Thanks for reporting -- it does really help. Kindly share any other concern you spot with omnistudio 248.
image

@deniskrizanovic
Copy link
Collaborator

WooHoo!

@rajeshkeswani
Copy link
Author

@eschweitzer78 : Thanks for your quick help here! I will close the bug once fixed in REV sandbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants