Fix for #188, widget field errors not displaying #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While I like the idea of `catch`, this fixes the problem. It makes sense if the actions are FSAs, since error better not be present if there's no error. Thoughts? ref: erikras#188
|
As a newcomer, it was an exercise figuring out the pipes in this.. not that it wasn't fun =) However, it may make sense to have form-submission-specific middleware, so that it may simply return a rejected promise, instead of having to code that logic into the component? |
|
Or maybe simply a helper for the handleSubmit function argument that checks for |
erikras
added a commit
that referenced
this pull request
Sep 16, 2015
Fix for #188, widget field errors not displaying
|
I like it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I like the idea of
catch, this fixes the problem. It makes sense if the actions are FSAs, since error better not be present if there's no error. Thoughts?ref: #188