Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widgets: nested color errors are not displaying #188

Closed
quicksnap opened this issue Sep 14, 2015 · 2 comments
Closed

Widgets: nested color errors are not displaying #188

quicksnap opened this issue Sep 14, 2015 · 2 comments

Comments

@quicksnap
Copy link
Collaborator

When I choose "green" as a color, I do not see any error feedback.

I'm looking into it now, will try and have a PR if I can find the problem before anyone else!
@erikras
Copy link
Owner

erikras commented Sep 14, 2015

It's related to this. When I had it returning Promise.reject(), the color error showed, but it caused other problems.

It needs more thought and research.

@quicksnap
Copy link
Collaborator Author

I'm was just checking out this repo yesterday, and I'm completely new to redux-form as well. Is this an issue with data coming back from redux-form or is it more to do with the server/client area?

quicksnap added a commit to quicksnap/react-redux-universal-hot-example that referenced this issue Sep 16, 2015
@quicksnap
Fix for erikras#188, widget field errors not displaying
0cfee52 
While I like the idea of `catch`, this fixes the problem. It makes sense if the actions are FSAs, since error better not be present if there's no error. Thoughts?

ref: erikras#188
@quicksnap quicksnap mentioned this issue Sep 16, 2015
Merged
erikras added a commit that referenced this issue Sep 16, 2015
@erikras
Merge pull request #193 from quicksnap/patch-2
35dda22 
Fix for #188, widget field errors not displaying
erikras added a commit that referenced this issue Sep 17, 2015
@erikras
Merge branch 'master' into heroku
2007c65 
* master:
  updated links to supporting libraries
  upgraded to redux-form v1.6 and redux v3
  Change Reactiflux channel badge
  Fix for #188, widget field errors not displaying
  Replaced react-hot-loader with webpack-hot-middleware
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@quicksnap @erikras