Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Revert removal of file argument #168

Merged
merged 1 commit into from
Feb 15, 2019
Merged

Fix: Revert removal of file argument #168

merged 1 commit into from
Feb 15, 2019

Conversation

localheinz
Copy link
Member

This PR

  • reverts the removal of the file argument

Reverts #151.
Reverts #164.
Follows #166.

@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

Merging #168 into master will increase coverage by 1.99%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #168      +/-   ##
============================================
+ Coverage     79.87%   81.86%   +1.99%     
- Complexity       31       34       +3     
============================================
  Files             2        2              
  Lines           164      182      +18     
============================================
+ Hits            131      149      +18     
  Misses           33       33
Impacted Files Coverage Δ Complexity Δ
src/Command/NormalizeCommand.php 87.13% <100%> (+1.51%) 31 <1> (+3) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2724291...af0d40c. Read the comment docs.

@localheinz localheinz merged commit 4ea3cf3 into master Feb 15, 2019
@localheinz localheinz deleted the fix/file branch February 15, 2019 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant