Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Revert deprecation of file argument #166

Merged
merged 1 commit into from
Feb 15, 2019
Merged

Fix: Revert deprecation of file argument #166

merged 1 commit into from
Feb 15, 2019

Conversation

localheinz
Copy link
Member

This PR

  • reverts the deprecation of the file argument as it turns out that the same functionality cannot be achieved using the --working-dir option

Follows #143.
Fixes #165.

@localheinz localheinz added the bug label Feb 15, 2019
@localheinz localheinz self-assigned this Feb 15, 2019
@localheinz localheinz force-pushed the fix/file branch 2 times, most recently from 024841b to 8cecb7e Compare February 15, 2019 17:04
@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

Merging #166 into 1.x will decrease coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##                1.x     #166     +/-   ##
===========================================
- Coverage     82.77%   82.68%   -0.1%     
  Complexity       36       36             
===========================================
  Files             2        2             
  Lines           180      179      -1     
===========================================
- Hits            149      148      -1     
  Misses           31       31
Impacted Files Coverage Δ Complexity Δ
src/Command/NormalizeCommand.php 87.05% <100%> (-0.08%) 33 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d2cab6...0f0e647. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant