-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Startup ordering based on OSGi Capabilities #71
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ltiple times in its Export-Packages.
…don't need to manually start felix.scr first anymore.
…SPI Fly requirement.
…methods on fragments).
…Capability is. We should probably wrap up this logic somewhere else...
…which safely encapsulates the combinatoric stuff.
nedtwigg
changed the title
Handle OSGi Capabilities correctly
Startup ordering based on OSGi Capabilities
Feb 7, 2023
This was referenced Feb 7, 2023
nedtwigg
added a commit
that referenced
this pull request
Feb 8, 2023
…fic collections - forgot about this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far we have been completely ignoring the OSGi
Provide-Capability
andRequire-Capability
mechanism. When we let Atomos start every bundle, we get errors because the lazy bundles start before the workbench is ready. If we start the bundles ourselves, we get "unmet capability" errors which we have so far silenced by doing thisequo-ide/solstice/src/main/java/dev/equo/solstice/BundleContextAtomos.java
Line 71 in c6d44c8
So in this PR, we are going to take OSGi capabilities into account for bundle start ordering. That should mean that we don't need to start
org.apache.felix.scr
explicitly anymoreequo-ide/solstice/src/main/java/dev/equo/ide/BuildPluginIdeMain.java
Lines 264 to 266 in c6d44c8
I bet this is also what was going wrong in
UIEventTopic
isn't working #33So we might be able to make Atomos actually optional after this PR. Certainly the pure-Solstice will work better by the time this is done.