Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Startup ordering based on OSGi Capabilities #71

Merged
merged 37 commits into from
Feb 7, 2023
Merged

Conversation

nedtwigg
Copy link
Collaborator

@nedtwigg nedtwigg commented Feb 6, 2023

So far we have been completely ignoring the OSGi Provide-Capability and Require-Capability mechanism. When we let Atomos start every bundle, we get errors because the lazy bundles start before the workbench is ready. If we start the bundles ourselves, we get "unmet capability" errors which we have so far silenced by doing this

setHeader(atomos, Constants.REQUIRE_CAPABILITY, Collections.emptyList());

So in this PR, we are going to take OSGi capabilities into account for bundle start ordering. That should mean that we don't need to start org.apache.felix.scr explicitly anymore

solstice.start("org.apache.felix.scr");
solstice.startAllWithLazy(false);
solstice.start("org.eclipse.ui.ide.application");

I bet this is also what was going wrong in

So we might be able to make Atomos actually optional after this PR. Certainly the pure-Solstice will work better by the time this is done.

…don't need to manually start felix.scr first anymore.
@nedtwigg nedtwigg changed the title Handle OSGi Capabilities correctly Startup ordering based on OSGi Capabilities Feb 7, 2023
@nedtwigg nedtwigg marked this pull request as ready for review February 7, 2023 23:34
@nedtwigg nedtwigg merged commit 0803730 into main Feb 7, 2023
@nedtwigg nedtwigg deleted the feat/osgi-caabilities branch February 7, 2023 23:35
nedtwigg added a commit that referenced this pull request Feb 8, 2023
…fic collections - forgot about this case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant