Regenerate OSGi capabilities after some have been removed

[nedtwigg]

EDIT @nedtwigg : The following has been implemented by

• Remove missing OSGi capabilities #80

so it is fixed for pure-Solstice. Integrating this fix fully into the Atomos integration will require a little more work.

---

We finally added full startup-ordering based on OSGi capabilities in

• Startup ordering based on OSGi Capabilities #71

but there's something missing from how we did it. Set aside capabilities for now look instead at packages and bundles. For those, we do the following:

1. calculate what is missing

equo-ide/solstice/src/main/java/dev/equo/solstice/Solstice.java

Lines 197 to 204 in 7e89542

	var missingBundles = calculateMissingBundles(bySymbolicName.keySet());
	missingBundles.forEach(
	(missing, neededBy) -> {
	logger.warn("Missing required bundle " + missing + " needed by " + neededBy);
	});
	var missingPackages = calculateMissingPackages(byExportedPackage.keySet());
	missingPackages.forEach(
	(missing, neededBy) -> {

2. remove those requirements from all SolsticeManifests

equo-ide/solstice/src/main/java/dev/equo/solstice/Solstice.java

Lines 216 to 219 in 7e89542

	for (var bundle : bundles) {
	bundle.removeFromRequiredBundles(missingBundles.keySet());
	bundle.removeFromPkgImports(missingPackages.keySet());
	}

3. problem solved for BundleContextSolstice, but for BundleContextAtomos we have to regenerate the header string from the SolsticeManifest metadata

equo-ide/solstice/src/main/java/dev/equo/solstice/BundleContextAtomos.java

Lines 65 to 71 in 7e89542

	public Map<String, String> atomosHeaders(SolsticeManifest manifest) {
	Map<String, String> atomos = new LinkedHashMap<>(manifest.getHeadersOriginal());
	setHeader(atomos, Constants.IMPORT_PACKAGE, manifest.pkgImports);
	setHeader(atomos, Constants.EXPORT_PACKAGE, manifest.pkgExports);
	setHeader(atomos, Constants.REQUIRE_BUNDLE, manifest.requiredBundles);
	return atomos;
	}

---

When it comes to capabilities, we can calculate what to remove

equo-ide/solstice/src/main/java/dev/equo/solstice/Solstice.java

Lines 221 to 229 in 7e89542

	// warn about missing requirements. TODO: remove missing requirements and set them in Atomos
	var allCapabilities = new Capability.SupersetSet();
	for (var bundle : bundles) {
	allCapabilities.addAll(bundle.capProvides);
	}
	for (var bundle : bundles) {
	for (var cap : bundle.capRequires) {
	if (!allCapabilities.containsAnySupersetOf(cap)) {
	logger.warn("Missing capability " + cap + " required by " + bundle);

But we don't remove it from SolsticeManifest. Because we don't remove it from the manifests, we have to tolerate missing requirements like this, but we should really throw the commented out exception.

equo-ide/solstice/src/main/java/dev/equo/solstice/Solstice.java

Lines 343 to 349 in 7e89542

	Capability cap;
	while ((cap = missingCap(manifest)) != null) {
	var bundles = unactivatedBundlesForCap(cap);
	if (bundles.isEmpty()) {
	logger.warn("{} requires missing capability {}", manifest, cap);
	caps.add(cap);
	// throw new IllegalArgumentException(manifest + " requires missing capability " + cap);

It's easy to fix within SolsticeManifest and BundleContextSolstice, but it's alot harder for BundleContextAtomos because there we will have to regenerate the full header string. The tricky thing is that the Capability we parse does not have everything that the OSGi runtime needs. We could expand the capability to do that, but all we actually need is full deletion of a matched capability, so probably it's easier to do removeCapabilities(Collection<Capability> cap) and have that operate on these implementation-details linked below

equo-ide/solstice/src/main/java/dev/equo/solstice/SolsticeManifest.java

Lines 178 to 225 in 7e89542

	private List<CapabilityParsed> parseAndStripCapability(String header) {
	try {
	String capability = headersOriginal.get(header);
	if (capability == null) {
	return Collections.emptyList();
	}
	// org.eclipse.ecf.identity has these gunky quotes
	capability = capability.replace('”', '"');
	ManifestElement[] elements = ManifestElement.parseHeader(header, capability);
	List<CapabilityParsed> capabilities = new ArrayList<>(elements.length);
	for (ManifestElement element : elements) {
	if (Capability.IGNORED_NAMESPACES.contains(element.getValue())) {
	continue;
	}
	capabilities.add(new CapabilityParsed(element));
	}
	if (capabilities.isEmpty()) {
	return Collections.emptyList();
	} else {
	return capabilities;
	}
	} catch (BundleException e) {
	throw Unchecked.wrap(e);
	}
	}
	private static class CapabilityParsed {
	String namespace;
	Map<String, String> attributes = new TreeMap<>();
	Map<String, String> directives = new TreeMap<>();
	public CapabilityParsed(ManifestElement element) {
	namespace = element.getValue();
	var keys = element.getKeys();
	if (keys != null) {
	while (keys.hasMoreElements()) {
	String key = keys.nextElement();
	if (!Capability.IGNORED_ATTRIBUTES.contains(key)) {
	this.attributes.put(key, element.getAttribute(key));
	}
	}
	}
	var directives = element.getDirectiveKeys();
	if (directives != null) {
	while (directives.hasMoreElements()) {
	String key = directives.nextElement();
	if (key.equals(Constants.FILTER_DIRECTIVE)) {
	this.directives.put(