Fix issue with from_pandas #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eivindjahren
force-pushed
the
fix_issue_with_from_pandas
branch
9 times, most recently
from
4d15182 to
e165fac
Compare
sondreso
approved these changes
Aug 12, 2024
eivindjahren
force-pushed
the
fix_issue_with_from_pandas
branch
from
e165fac to
4b18683
Compare
Split it now |
🚀 Go for merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #944
The PR duplicates the generator code from the ert test code. I think that is preferable to trying to reuse this code in both places as test failures will be difficult to debug, and we would likely want to modify the generators so that
summaries()generates aresdata.summary.SummaryThis breaks one test case from 1a41876 , but it seems like this synthetic data does not reflect how these fields should be interpreted.