Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in _compile_headers_list #944

Closed
alifbe opened this issue Jan 8, 2024 · 0 comments · Fixed by #1000
Closed

Bug in _compile_headers_list #944

alifbe opened this issue Jan 8, 2024 · 0 comments · Fixed by #1000
Assignees
Labels

Comments

@alifbe
Copy link

alifbe commented Jan 8, 2024

In _compile_headers_list there is a check if the first character of wgnames is numeric or not. If it's numeric then it's assumed to be either cell/block coordinate (i, j, k) or region/aquifer index.

if lst[1][0].isdigit():

This will fail if for example the well name is starting with number.

Suggestion, add more check to the keyword, for example, ensure they are not well vectors (WOPR, WWCT, etc) and not a segment vectors (SOFR, SWFR etc)

if lst[1][0].isdigit() and kw[0] not in ['W', 'S']:
    nums = re.split(",", lst[1])
else:
    wgname = lst[1]
@berland berland added this to SCOUT Apr 8, 2024
@berland berland moved this to Todo in SCOUT Apr 8, 2024
@pinkwah pinkwah moved this from Todo to In Progress in SCOUT Apr 17, 2024
@xjules xjules moved this from In Progress to Backlog in SCOUT May 29, 2024
@eivindjahren eivindjahren moved this from Backlog to In Progress in SCOUT Aug 12, 2024
@eivindjahren eivindjahren self-assigned this Aug 12, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in SCOUT Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants