♻️ Refactor Search to use new InputWrapper
#2481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mimarz
changed the title
Search to use new InputSearch to use new InputWrapper
mimarz
changed the title
Search to use new InputWrapperSearch to use new InputWrapper
mimarz
added a commit
that referenced
this pull request
Sep 21, 2022
* ♻️ Initial rewrite of Search * ♻️ Re-introduce height on input due to compact * 📝 Updated search docs * ♻️ Introduces Inputwrapper * ✅ Updated test * 🐛 Fixed bugs * 🗑️ Clean code * Updated snapshots * 🔥 Removed unused files
mimarz
added a commit
that referenced
this pull request
Oct 4, 2022
* ♻️ Initial rewrite of Search * ♻️ Re-introduce height on input due to compact * 📝 Updated search docs * ♻️ Introduces Inputwrapper * ✅ Updated test * 🐛 Fixed bugs * 🗑️ Clean code * Updated snapshots * 🔥 Removed unused files
mimarz
added a commit
that referenced
this pull request
Oct 7, 2022
* ♻️ Initial rewrite of Search * ♻️ Re-introduce height on input due to compact * 📝 Updated search docs * ♻️ Introduces Inputwrapper * ✅ Updated test * 🐛 Fixed bugs * 🗑️ Clean code * Updated snapshots * 🔥 Removed unused files
mimarz
added a commit
that referenced
this pull request
Oct 11, 2022
* ♻️ Initial rewrite of Search * ♻️ Re-introduce height on input due to compact * 📝 Updated search docs * ♻️ Introduces Inputwrapper * ✅ Updated test * 🐛 Fixed bugs * 🗑️ Clean code * Updated snapshots * 🔥 Removed unused files
mimarz
added a commit
that referenced
this pull request
Oct 13, 2022
* ♻️ Initial rewrite of Search * ♻️ Re-introduce height on input due to compact * 📝 Updated search docs * ♻️ Introduces Inputwrapper * ✅ Updated test * 🐛 Fixed bugs * 🗑️ Clean code * Updated snapshots * 🔥 Removed unused files
mimarz
added a commit
that referenced
this pull request
Oct 18, 2022
* ♻️ Initial rewrite of Search * ♻️ Re-introduce height on input due to compact * 📝 Updated search docs * ♻️ Introduces Inputwrapper * ✅ Updated test * 🐛 Fixed bugs * 🗑️ Clean code * Updated snapshots * 🔥 Removed unused files
mimarz
added a commit
that referenced
this pull request
Oct 18, 2022
* ✨ Adornments support in `Input` component (#2354) * 🚧 WIP * 📝 Added story * wip * 🚧 WIP * 🚧 WIP * 🚧 wip * 🚚 Moved over `Input` adornment changes * ♻️ Added `OldInput` for interim development * 🐛 Fixed textarea outline * ♻️ back to new input * 🔥 removed OldInput * Testing something old * updated snapshots * its something * ♻️ working version before testing styles * ♻️ Further testing and tweaking * 📸 ✅ Updated test & snapshots * ♻️ working example * 🚚 Moved typographymixin * ♻️ Started cleaning up helpertext * 📸 Updated snapshots * Working example with colored helpertext * 🚧 WIP * 🚧 WIP * tweaks * Added description * ♻️ Textfield using `InputWrapper` (#2416) * ✨ Adornments support in `Input` component (#2354) * 🚧 WIP * 📝 Added story * wip * 🚧 WIP * 🚧 WIP * 🚧 wip * 🚚 Moved over `Input` adornment changes * ♻️ Added `OldInput` for interim development * 🐛 Fixed textarea outline * ♻️ back to new input * 🔥 removed OldInput * Testing something old * updated snapshots * its something * ♻️ working version before testing styles * ♻️ Further testing and tweaking * 📸 ✅ Updated test & snapshots * ♻️ working example * 🚚 Moved typographymixin * ♻️ Started cleaning up helpertext * ♻️ Working with just input * 🚧 WIP * ♻️ Fixed helper text & colors * ♻️ changed to usecallback * ⚰️ Removed unused files * ♻️ improvements to input * ♻️ Simplified adornment width * 🐛 Fixed new variant in Textarea * ♻️ Textfield with discriminating union * ♻️ re-introduced old proxy component * Fiex typing * 🗑️ Cleaning up files * Added overridablecomponent to input * 🏷️ Made as optional in overridableComponent * 🐛 Fix aria-describedby when no helpertext is provided * ♻️ Updated Textarea with input * Cleaning up helpertext * ♻️ Tweak adornments * 📸 Update snapshots * ♻️ Working textarea within Textfield * ⏪ Reverted adornment styling changes * Cleanup * ♻️ Update Textfield rstories * 📸 Update snapshots * ♻️ Re-added support for manual width * ♻️ Refactor `Search` to use new `InputWrapper` (#2481) * ♻️ Initial rewrite of Search * ♻️ Re-introduce height on input due to compact * 📝 Updated search docs * ♻️ Introduces Inputwrapper * ✅ Updated test * 🐛 Fixed bugs * 🗑️ Clean code * Updated snapshots * 🔥 Removed unused files * 🐛 Fixed height for when multilines * 📸 Updated snapshots * 🚨 Cleaned up some linting warnings * 📝 Wording
denektenina
pushed a commit
to denektenina/design-system
that referenced
this pull request
Oct 19, 2022
* ✨ Adornments support in `Input` component (equinor#2354) * 🚧 WIP * 📝 Added story * wip * 🚧 WIP * 🚧 WIP * 🚧 wip * 🚚 Moved over `Input` adornment changes * ♻️ Added `OldInput` for interim development * 🐛 Fixed textarea outline * ♻️ back to new input * 🔥 removed OldInput * Testing something old * updated snapshots * its something * ♻️ working version before testing styles * ♻️ Further testing and tweaking * 📸 ✅ Updated test & snapshots * ♻️ working example * 🚚 Moved typographymixin * ♻️ Started cleaning up helpertext * 📸 Updated snapshots * Working example with colored helpertext * 🚧 WIP * 🚧 WIP * tweaks * Added description * ♻️ Textfield using `InputWrapper` (equinor#2416) * ✨ Adornments support in `Input` component (equinor#2354) * 🚧 WIP * 📝 Added story * wip * 🚧 WIP * 🚧 WIP * 🚧 wip * 🚚 Moved over `Input` adornment changes * ♻️ Added `OldInput` for interim development * 🐛 Fixed textarea outline * ♻️ back to new input * 🔥 removed OldInput * Testing something old * updated snapshots * its something * ♻️ working version before testing styles * ♻️ Further testing and tweaking * 📸 ✅ Updated test & snapshots * ♻️ working example * 🚚 Moved typographymixin * ♻️ Started cleaning up helpertext * ♻️ Working with just input * 🚧 WIP * ♻️ Fixed helper text & colors * ♻️ changed to usecallback * ⚰️ Removed unused files * ♻️ improvements to input * ♻️ Simplified adornment width * 🐛 Fixed new variant in Textarea * ♻️ Textfield with discriminating union * ♻️ re-introduced old proxy component * Fiex typing * 🗑️ Cleaning up files * Added overridablecomponent to input * 🏷️ Made as optional in overridableComponent * 🐛 Fix aria-describedby when no helpertext is provided * ♻️ Updated Textarea with input * Cleaning up helpertext * ♻️ Tweak adornments * 📸 Update snapshots * ♻️ Working textarea within Textfield * ⏪ Reverted adornment styling changes * Cleanup * ♻️ Update Textfield rstories * 📸 Update snapshots * ♻️ Re-added support for manual width * ♻️ Refactor `Search` to use new `InputWrapper` (equinor#2481) * ♻️ Initial rewrite of Search * ♻️ Re-introduce height on input due to compact * 📝 Updated search docs * ♻️ Introduces Inputwrapper * ✅ Updated test * 🐛 Fixed bugs * 🗑️ Clean code * Updated snapshots * 🔥 Removed unused files * 🐛 Fixed height for when multilines * 📸 Updated snapshots * 🚨 Cleaned up some linting warnings * 📝 Wording
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2473