Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Textfield using InputWrapper #2416

Merged

Conversation

mimarz
Copy link
Contributor

@mimarz mimarz commented Aug 16, 2022

resolves #2407

@mimarz mimarz changed the title ♻️ Working with just input ♻️ Textfield using InputWrapper Aug 16, 2022
@mimarz mimarz force-pushed the feat/MIM-2407-textfield-with-inputwrapper branch from 3822e91 to fd8f0f4 Compare August 25, 2022 10:20
@mimarz mimarz force-pushed the feat/2336-inputwrapper branch from 7c5bbbf to 8864792 Compare September 5, 2022 13:27
* 🚧 WIP

* 📝 Added story

* wip

* 🚧 WIP

* 🚧 WIP

* 🚧 wip

* 🚚 Moved over `Input` adornment changes

* ♻️ Added `OldInput` for interim development

* 🐛 Fixed textarea outline

* ♻️ back to new input

* 🔥 removed OldInput

* Testing something old

* updated snapshots

* its something

* ♻️ working version before testing styles

* ♻️ Further testing and tweaking

* 📸 ✅ Updated test & snapshots

* ♻️ working example

* 🚚 Moved typographymixin

* ♻️ Started cleaning up helpertext
@mimarz mimarz force-pushed the feat/MIM-2407-textfield-with-inputwrapper branch from fd8f0f4 to 47a2c52 Compare September 6, 2022 07:11
@mimarz mimarz marked this pull request as ready for review September 8, 2022 07:10
@mimarz mimarz requested a review from vnys as a code owner September 8, 2022 07:10
@mimarz mimarz merged commit e2fdde1 into feat/2336-inputwrapper Sep 8, 2022
@mimarz mimarz deleted the feat/MIM-2407-textfield-with-inputwrapper branch September 8, 2022 07:59
mimarz added a commit that referenced this pull request Sep 21, 2022
* ✨ Adornments support in `Input` component (#2354)

* 🚧 WIP

* 📝 Added story

* wip

* 🚧 WIP

* 🚧 WIP

* 🚧 wip

* 🚚 Moved over `Input` adornment changes

* ♻️ Added `OldInput` for interim development

* 🐛 Fixed textarea outline

* ♻️ back to new input

* 🔥 removed OldInput

* Testing something old

* updated snapshots

* its something

* ♻️ working version before testing styles

* ♻️ Further testing and tweaking

* 📸 ✅ Updated test & snapshots

* ♻️ working example

* 🚚 Moved typographymixin

* ♻️ Started cleaning up helpertext

* ♻️ Working with just input

* 🚧 WIP

* ♻️ Fixed helper text & colors

* ♻️ changed to usecallback

* ⚰️ Removed unused files

* ♻️ improvements to input

* ♻️ Simplified adornment width

* 🐛 Fixed new variant in Textarea

* ♻️ Textfield with discriminating union

* ♻️ re-introduced old proxy component

* Fiex typing

* 🗑️ Cleaning up files

* Added overridablecomponent to input

* 🏷️ Made as optional in overridableComponent

* 🐛 Fix aria-describedby when no helpertext is provided

* ♻️ Updated Textarea with input

* Cleaning up helpertext

* ♻️ Tweak adornments

* 📸 Update snapshots

* ♻️ Working textarea within Textfield

* ⏪ Reverted adornment styling changes

* Cleanup

* ♻️ Update Textfield rstories
mimarz added a commit that referenced this pull request Oct 4, 2022
* ✨ Adornments support in `Input` component (#2354)

* 🚧 WIP

* 📝 Added story

* wip

* 🚧 WIP

* 🚧 WIP

* 🚧 wip

* 🚚 Moved over `Input` adornment changes

* ♻️ Added `OldInput` for interim development

* 🐛 Fixed textarea outline

* ♻️ back to new input

* 🔥 removed OldInput

* Testing something old

* updated snapshots

* its something

* ♻️ working version before testing styles

* ♻️ Further testing and tweaking

* 📸 ✅ Updated test & snapshots

* ♻️ working example

* 🚚 Moved typographymixin

* ♻️ Started cleaning up helpertext

* ♻️ Working with just input

* 🚧 WIP

* ♻️ Fixed helper text & colors

* ♻️ changed to usecallback

* ⚰️ Removed unused files

* ♻️ improvements to input

* ♻️ Simplified adornment width

* 🐛 Fixed new variant in Textarea

* ♻️ Textfield with discriminating union

* ♻️ re-introduced old proxy component

* Fiex typing

* 🗑️ Cleaning up files

* Added overridablecomponent to input

* 🏷️ Made as optional in overridableComponent

* 🐛 Fix aria-describedby when no helpertext is provided

* ♻️ Updated Textarea with input

* Cleaning up helpertext

* ♻️ Tweak adornments

* 📸 Update snapshots

* ♻️ Working textarea within Textfield

* ⏪ Reverted adornment styling changes

* Cleanup

* ♻️ Update Textfield rstories
mimarz added a commit that referenced this pull request Oct 7, 2022
* ✨ Adornments support in `Input` component (#2354)

* 🚧 WIP

* 📝 Added story

* wip

* 🚧 WIP

* 🚧 WIP

* 🚧 wip

* 🚚 Moved over `Input` adornment changes

* ♻️ Added `OldInput` for interim development

* 🐛 Fixed textarea outline

* ♻️ back to new input

* 🔥 removed OldInput

* Testing something old

* updated snapshots

* its something

* ♻️ working version before testing styles

* ♻️ Further testing and tweaking

* 📸 ✅ Updated test & snapshots

* ♻️ working example

* 🚚 Moved typographymixin

* ♻️ Started cleaning up helpertext

* ♻️ Working with just input

* 🚧 WIP

* ♻️ Fixed helper text & colors

* ♻️ changed to usecallback

* ⚰️ Removed unused files

* ♻️ improvements to input

* ♻️ Simplified adornment width

* 🐛 Fixed new variant in Textarea

* ♻️ Textfield with discriminating union

* ♻️ re-introduced old proxy component

* Fiex typing

* 🗑️ Cleaning up files

* Added overridablecomponent to input

* 🏷️ Made as optional in overridableComponent

* 🐛 Fix aria-describedby when no helpertext is provided

* ♻️ Updated Textarea with input

* Cleaning up helpertext

* ♻️ Tweak adornments

* 📸 Update snapshots

* ♻️ Working textarea within Textfield

* ⏪ Reverted adornment styling changes

* Cleanup

* ♻️ Update Textfield rstories
mimarz added a commit that referenced this pull request Oct 11, 2022
* ✨ Adornments support in `Input` component (#2354)

* 🚧 WIP

* 📝 Added story

* wip

* 🚧 WIP

* 🚧 WIP

* 🚧 wip

* 🚚 Moved over `Input` adornment changes

* ♻️ Added `OldInput` for interim development

* 🐛 Fixed textarea outline

* ♻️ back to new input

* 🔥 removed OldInput

* Testing something old

* updated snapshots

* its something

* ♻️ working version before testing styles

* ♻️ Further testing and tweaking

* 📸 ✅ Updated test & snapshots

* ♻️ working example

* 🚚 Moved typographymixin

* ♻️ Started cleaning up helpertext

* ♻️ Working with just input

* 🚧 WIP

* ♻️ Fixed helper text & colors

* ♻️ changed to usecallback

* ⚰️ Removed unused files

* ♻️ improvements to input

* ♻️ Simplified adornment width

* 🐛 Fixed new variant in Textarea

* ♻️ Textfield with discriminating union

* ♻️ re-introduced old proxy component

* Fiex typing

* 🗑️ Cleaning up files

* Added overridablecomponent to input

* 🏷️ Made as optional in overridableComponent

* 🐛 Fix aria-describedby when no helpertext is provided

* ♻️ Updated Textarea with input

* Cleaning up helpertext

* ♻️ Tweak adornments

* 📸 Update snapshots

* ♻️ Working textarea within Textfield

* ⏪ Reverted adornment styling changes

* Cleanup

* ♻️ Update Textfield rstories
mimarz added a commit that referenced this pull request Oct 13, 2022
* ✨ Adornments support in `Input` component (#2354)

* 🚧 WIP

* 📝 Added story

* wip

* 🚧 WIP

* 🚧 WIP

* 🚧 wip

* 🚚 Moved over `Input` adornment changes

* ♻️ Added `OldInput` for interim development

* 🐛 Fixed textarea outline

* ♻️ back to new input

* 🔥 removed OldInput

* Testing something old

* updated snapshots

* its something

* ♻️ working version before testing styles

* ♻️ Further testing and tweaking

* 📸 ✅ Updated test & snapshots

* ♻️ working example

* 🚚 Moved typographymixin

* ♻️ Started cleaning up helpertext

* ♻️ Working with just input

* 🚧 WIP

* ♻️ Fixed helper text & colors

* ♻️ changed to usecallback

* ⚰️ Removed unused files

* ♻️ improvements to input

* ♻️ Simplified adornment width

* 🐛 Fixed new variant in Textarea

* ♻️ Textfield with discriminating union

* ♻️ re-introduced old proxy component

* Fiex typing

* 🗑️ Cleaning up files

* Added overridablecomponent to input

* 🏷️ Made as optional in overridableComponent

* 🐛 Fix aria-describedby when no helpertext is provided

* ♻️ Updated Textarea with input

* Cleaning up helpertext

* ♻️ Tweak adornments

* 📸 Update snapshots

* ♻️ Working textarea within Textfield

* ⏪ Reverted adornment styling changes

* Cleanup

* ♻️ Update Textfield rstories
mimarz added a commit that referenced this pull request Oct 18, 2022
* ✨ Adornments support in `Input` component (#2354)

* 🚧 WIP

* 📝 Added story

* wip

* 🚧 WIP

* 🚧 WIP

* 🚧 wip

* 🚚 Moved over `Input` adornment changes

* ♻️ Added `OldInput` for interim development

* 🐛 Fixed textarea outline

* ♻️ back to new input

* 🔥 removed OldInput

* Testing something old

* updated snapshots

* its something

* ♻️ working version before testing styles

* ♻️ Further testing and tweaking

* 📸 ✅ Updated test & snapshots

* ♻️ working example

* 🚚 Moved typographymixin

* ♻️ Started cleaning up helpertext

* ♻️ Working with just input

* 🚧 WIP

* ♻️ Fixed helper text & colors

* ♻️ changed to usecallback

* ⚰️ Removed unused files

* ♻️ improvements to input

* ♻️ Simplified adornment width

* 🐛 Fixed new variant in Textarea

* ♻️ Textfield with discriminating union

* ♻️ re-introduced old proxy component

* Fiex typing

* 🗑️ Cleaning up files

* Added overridablecomponent to input

* 🏷️ Made as optional in overridableComponent

* 🐛 Fix aria-describedby when no helpertext is provided

* ♻️ Updated Textarea with input

* Cleaning up helpertext

* ♻️ Tweak adornments

* 📸 Update snapshots

* ♻️ Working textarea within Textfield

* ⏪ Reverted adornment styling changes

* Cleanup

* ♻️ Update Textfield rstories
mimarz added a commit that referenced this pull request Oct 18, 2022
* ✨ Adornments support in `Input` component (#2354)

* 🚧 WIP

* 📝 Added story

* wip

* 🚧 WIP

* 🚧 WIP

* 🚧 wip

* 🚚 Moved over `Input` adornment changes

* ♻️ Added `OldInput` for interim development

* 🐛 Fixed textarea outline

* ♻️ back to new input

* 🔥 removed OldInput

* Testing something old

* updated snapshots

* its something

* ♻️ working version before testing styles

* ♻️ Further testing and tweaking

* 📸 ✅ Updated test & snapshots

* ♻️ working example

* 🚚 Moved typographymixin

* ♻️ Started cleaning up helpertext

* 📸 Updated snapshots

* Working example with colored helpertext

* 🚧 WIP

* 🚧 WIP

* tweaks

* Added description

* ♻️ Textfield using `InputWrapper` (#2416)

* ✨ Adornments support in `Input` component (#2354)

* 🚧 WIP

* 📝 Added story

* wip

* 🚧 WIP

* 🚧 WIP

* 🚧 wip

* 🚚 Moved over `Input` adornment changes

* ♻️ Added `OldInput` for interim development

* 🐛 Fixed textarea outline

* ♻️ back to new input

* 🔥 removed OldInput

* Testing something old

* updated snapshots

* its something

* ♻️ working version before testing styles

* ♻️ Further testing and tweaking

* 📸 ✅ Updated test & snapshots

* ♻️ working example

* 🚚 Moved typographymixin

* ♻️ Started cleaning up helpertext

* ♻️ Working with just input

* 🚧 WIP

* ♻️ Fixed helper text & colors

* ♻️ changed to usecallback

* ⚰️ Removed unused files

* ♻️ improvements to input

* ♻️ Simplified adornment width

* 🐛 Fixed new variant in Textarea

* ♻️ Textfield with discriminating union

* ♻️ re-introduced old proxy component

* Fiex typing

* 🗑️ Cleaning up files

* Added overridablecomponent to input

* 🏷️ Made as optional in overridableComponent

* 🐛 Fix aria-describedby when no helpertext is provided

* ♻️ Updated Textarea with input

* Cleaning up helpertext

* ♻️ Tweak adornments

* 📸 Update snapshots

* ♻️ Working textarea within Textfield

* ⏪ Reverted adornment styling changes

* Cleanup

* ♻️ Update Textfield rstories

* 📸 Update snapshots

* ♻️ Re-added support for manual width

* ♻️ Refactor `Search` to use new `InputWrapper` (#2481)

* ♻️ Initial rewrite of Search

* ♻️ Re-introduce height on input due to compact

* 📝 Updated search docs

* ♻️ Introduces Inputwrapper

* ✅ Updated test

* 🐛 Fixed bugs

* 🗑️ Clean code

* Updated snapshots

* 🔥 Removed unused files

* 🐛 Fixed height for when multilines

* 📸 Updated snapshots

* 🚨 Cleaned up some linting warnings

* 📝 Wording
denektenina pushed a commit to denektenina/design-system that referenced this pull request Oct 19, 2022
* ✨ Adornments support in `Input` component (equinor#2354)

* 🚧 WIP

* 📝 Added story

* wip

* 🚧 WIP

* 🚧 WIP

* 🚧 wip

* 🚚 Moved over `Input` adornment changes

* ♻️ Added `OldInput` for interim development

* 🐛 Fixed textarea outline

* ♻️ back to new input

* 🔥 removed OldInput

* Testing something old

* updated snapshots

* its something

* ♻️ working version before testing styles

* ♻️ Further testing and tweaking

* 📸 ✅ Updated test & snapshots

* ♻️ working example

* 🚚 Moved typographymixin

* ♻️ Started cleaning up helpertext

* 📸 Updated snapshots

* Working example with colored helpertext

* 🚧 WIP

* 🚧 WIP

* tweaks

* Added description

* ♻️ Textfield using `InputWrapper` (equinor#2416)

* ✨ Adornments support in `Input` component (equinor#2354)

* 🚧 WIP

* 📝 Added story

* wip

* 🚧 WIP

* 🚧 WIP

* 🚧 wip

* 🚚 Moved over `Input` adornment changes

* ♻️ Added `OldInput` for interim development

* 🐛 Fixed textarea outline

* ♻️ back to new input

* 🔥 removed OldInput

* Testing something old

* updated snapshots

* its something

* ♻️ working version before testing styles

* ♻️ Further testing and tweaking

* 📸 ✅ Updated test & snapshots

* ♻️ working example

* 🚚 Moved typographymixin

* ♻️ Started cleaning up helpertext

* ♻️ Working with just input

* 🚧 WIP

* ♻️ Fixed helper text & colors

* ♻️ changed to usecallback

* ⚰️ Removed unused files

* ♻️ improvements to input

* ♻️ Simplified adornment width

* 🐛 Fixed new variant in Textarea

* ♻️ Textfield with discriminating union

* ♻️ re-introduced old proxy component

* Fiex typing

* 🗑️ Cleaning up files

* Added overridablecomponent to input

* 🏷️ Made as optional in overridableComponent

* 🐛 Fix aria-describedby when no helpertext is provided

* ♻️ Updated Textarea with input

* Cleaning up helpertext

* ♻️ Tweak adornments

* 📸 Update snapshots

* ♻️ Working textarea within Textfield

* ⏪ Reverted adornment styling changes

* Cleanup

* ♻️ Update Textfield rstories

* 📸 Update snapshots

* ♻️ Re-added support for manual width

* ♻️ Refactor `Search` to use new `InputWrapper` (equinor#2481)

* ♻️ Initial rewrite of Search

* ♻️ Re-introduce height on input due to compact

* 📝 Updated search docs

* ♻️ Introduces Inputwrapper

* ✅ Updated test

* 🐛 Fixed bugs

* 🗑️ Clean code

* Updated snapshots

* 🔥 Removed unused files

* 🐛 Fixed height for when multilines

* 📸 Updated snapshots

* 🚨 Cleaned up some linting warnings

* 📝 Wording
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant