-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Potential naming conflict #325
Comments
Thanks for flagging, I had noticed this but didn't feel like it was likely to cause many issues. It does emphasise the notation and clarity of discussing packages, functions, and classes. At the moment, my preference is not to change anything. If we decided the class name should change then |
Tagging @jamesmbaazam as he mentioned the same thing recently. |
Yes, I was wondering if it would be worth discussing and fixing sooner rather than later. |
I don't think anything needs fixing, as it assumes something is broken. There is no technical conflict (e.g. namespace conflict) as the {epidist} package doesn't contain an Although changing the class names in {epiparameter} could be done quickly we don't want to break scripts using the package. Hence, why I've been hesitant to make this change straight away. I think the best next steps are to contact the maintainer(s) of {epidist} and discuss what would be best for both packages. What do you both think? |
The |
…er, also changed in file and function names, closes #325
Just flaggin that the
epidist
class vs.epidist
package might cause confusion in the futurehttps://github.com/epinowcast/epidist
The text was updated successfully, but these errors were encountered: