Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] epicli init --full does not generate configuration for OpenDistro #2966

Closed
6 of 18 tasks
przemyslavic opened this issue Feb 9, 2022 · 1 comment
Closed
6 of 18 tasks
Assignees
Labels

Comments

@przemyslavic
Copy link
Collaborator

przemyslavic commented Feb 9, 2022

Describe the bug
epicli init --full does not generate configuration for OpenDistro. There is no kind: configuration/opendistro-for-elasticsearch in the output file.
Probably the reason is that OpenDistro component is set to 0 by default and therefore no configuration is generated for it.
https://github.com/epiphany-platform/epiphany/blob/develop/schema/aws/defaults/configuration/minimal-cluster-config.yml
https://github.com/epiphany-platform/epiphany/blob/develop/schema/aws/defaults/epiphany-cluster.yml

Note: Fix should be applied to all providers.

To work around: add kind: configuration/opendistro-for-elasticsearch manually and adjust it to your needs or do nothing to use defaults.

However, I think that epicli init --full should generate the full configuration for each component.

Please also see: #2968.

How to reproduce
Steps to reproduce the behavior:

  1. execute epicli init -p {aws, azure, any} -n test --full
  2. Verify generated file

Expected behavior
There should exist a configuration for each component, including OpenDistro.

Environment

  • Cloud provider: [all]
  • OS: [all]

epicli version: [2.0.0dev]


DoD checklist

  • Changelog
    • updated
    • not needed
  • COMPONENTS.md
    • updated
    • not needed
  • Schema
    • updated
    • not needed
  • Backport tasks
    • created
    • not needed
  • Documentation
    • added
    • updated
    • not needed
  • Feature has automated tests
  • Automated tests passed (QA pipelines)
    • apply
    • upgrade
    • backup/restore
  • Idempotency tested
  • All conversations in PR resolved
@przemyslavic
Copy link
Collaborator Author

Added the OpenDistro machine to the minimal cluster config.
Additionally, the configuration for kind: configuration/opendistro-for-elasticsearch is generated with the init --full command.

@przemyslavic przemyslavic self-assigned this Feb 28, 2022
@seriva seriva closed this as completed Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants