-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make logo transparent outside hex for dark mode #363
Comments
FWIW I don't think a logo having whitespace on darkmode is "high priority" |
IMO this is high as it represents a reduction in package quality of what we had previously/a bug if we had seen it in #361 we wouldn't have merged that PR. We can't seriously share the package whilst its here in my view |
I'd say this is overly strong, but fair enough. The challenge here is having a figure which hits the boundaries of the hex. With |
This wasn't an issue previously right so reverting is something to consider if we want a quick fix (and could just revert the plot size change). I struggle to see how this can't be a very fixed issue elsewhere in package land though. |
I think easy fix will do soon |
You might want to consider this over at |
Originally posted by @seabbs in #353 (comment)
The text was updated successfully, but these errors were encountered: