Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make logo transparent outside hex for dark mode #363

Closed
athowes opened this issue Oct 2, 2024 · 7 comments · Fixed by #364
Closed

Make logo transparent outside hex for dark mode #363

athowes opened this issue Oct 2, 2024 · 7 comments · Fixed by #364
Labels
bug Something isn't working high Required for next release

Comments

@athowes
Copy link
Collaborator

athowes commented Oct 2, 2024

          (look in dark mode)

Originally posted by @seabbs in #353 (comment)

@athowes athowes added the low For a future release label Oct 2, 2024
@seabbs seabbs added high Required for next release and removed low For a future release labels Oct 2, 2024
@athowes
Copy link
Collaborator Author

athowes commented Oct 2, 2024

FWIW I don't think a logo having whitespace on darkmode is "high priority"

@seabbs
Copy link
Contributor

seabbs commented Oct 2, 2024

IMO this is high as it represents a reduction in package quality of what we had previously/a bug if we had seen it in #361 we wouldn't have merged that PR.

We can't seriously share the package whilst its here in my view

@seabbs seabbs added the bug Something isn't working label Oct 2, 2024
@athowes
Copy link
Collaborator Author

athowes commented Oct 2, 2024

We can't seriously share the package whilst its here in my view

I'd say this is overly strong, but fair enough.

The challenge here is having a figure which hits the boundaries of the hex. With white_around_sticker = FALSE it leaves plot outside the sticker. To me having the plot not hit the bounds of the sticker makes the plot too small.

@seabbs
Copy link
Contributor

seabbs commented Oct 2, 2024

This wasn't an issue previously right so reverting is something to consider if we want a quick fix (and could just revert the plot size change). I struggle to see how this can't be a very fixed issue elsewhere in package land though.

@athowes
Copy link
Collaborator Author

athowes commented Oct 2, 2024

@athowes
Copy link
Collaborator Author

athowes commented Oct 2, 2024

I think easy fix will do soon

@athowes
Copy link
Collaborator Author

athowes commented Oct 2, 2024

Solution is here https://stackoverflow.com/questions/60426922/trim-around-hexagon-shape-with-hexsticker

You might want to consider this over at EpiNow2 as looks to me like there will be same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high Required for next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants