Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve hex sticker #353

Closed
athowes opened this issue Sep 25, 2024 · 12 comments · Fixed by #361
Closed

Improve hex sticker #353

athowes opened this issue Sep 25, 2024 · 12 comments · Fixed by #361
Labels
low For a future release

Comments

@athowes
Copy link
Collaborator

athowes commented Sep 25, 2024

Make this better:

image

@athowes athowes added the low For a future release label Sep 25, 2024
@athowes
Copy link
Collaborator Author

athowes commented Sep 27, 2024

My wishlist for this being better:

  • It seems pretty low quality (pixelated) currently
  • Make the figure larger to take up more of the space and be flush against the sides
  • Perhaps text darker
  • Change colours of figure
  • Is there any way to convey that the epidist estimate allows you to recover the correct histogram as compared with the incorrect biased one? Make the epidist text the same colour as the correct histogram? (Also note, are we using epidist to fit this? I think it might just be retrospective / correct so maybe should actually use the package function here).

@seabbs
Copy link
Contributor

seabbs commented Oct 1, 2024

I was fairly happy with it with the previous colour scheme to be honest

@seabbs
Copy link
Contributor

seabbs commented Oct 1, 2024

In terms of res just store a higher res original and then use use_this for the generation of the stuff that will be used everywhere else

@athowes
Copy link
Collaborator Author

athowes commented Oct 2, 2024

Opinions on:

image

@athowes
Copy link
Collaborator Author

athowes commented Oct 2, 2024

usethis::use_logo doesn't seem to do anything apart from put it in man/figures/logo.png so unsure it has a purpose.

@seabbs
Copy link
Contributor

seabbs commented Oct 2, 2024

it generates a bunch of favicons for pkgdown and resizes it appropriately I believe.

@athowes
Copy link
Collaborator Author

athowes commented Oct 2, 2024

it generates a bunch of favicons for pkgdown and resizes it appropriately I believe.

It doesn't generate files other than man/figures/logo.png for me.

@seabbs
Copy link
Contributor

seabbs commented Oct 2, 2024

https://pkgdown.r-lib.org/reference/build_favicons.html

@seabbs
Copy link
Contributor

seabbs commented Oct 2, 2024

I like the colour scheme reversion. I don't love the zoom on the partial distribution but I don't ultimately mind that much so happy to go forward with it if its your preference

seabbs pushed a commit that referenced this issue Oct 2, 2024
* Proposal for better logo

* usethis::use_logo and pkgdown::build_favicons
@seabbs seabbs reopened this Oct 2, 2024
@seabbs
Copy link
Contributor

seabbs commented Oct 2, 2024

See: https://github.com/epinowcast/epidist

We may need usethis:use_logo or similar approaches to dealing with whitespace after all.

@seabbs
Copy link
Contributor

seabbs commented Oct 2, 2024

(look in dark mode)

@seabbs
Copy link
Contributor

seabbs commented Oct 2, 2024

Closed in favour of #363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low For a future release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants