Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import DataFunctionArgs from @remix-run/node instead of @remix-run/server-runtime #576

Merged
merged 1 commit into from
Dec 28, 2023
Merged

import DataFunctionArgs from @remix-run/node instead of @remix-run/server-runtime #576

merged 1 commit into from
Dec 28, 2023

Conversation

theMosaad
Copy link
Contributor

Import DataFunctionArgs type from @remix-run/node instead of @remix-run/server-runtime to maintain consistency with the rest of the app.

kentcdodds
kentcdodds approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds kentcdodds merged commit 2db4470 into epicweb-dev:main Dec 28, 2023
@kiliman
Copy link
Contributor

kiliman commented Dec 28, 2023

I believe they are deprecating DataFunctionArgs in favor of LoaderFunctionArgs and ActionFunctionArgs

remix-run/remix#8089

@kiliman
Copy link
Contributor

kiliman commented Dec 28, 2023

Never mind. I see you've addressed it in #573

@theMosaad theMosaad deleted the patch-1 branch December 28, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theMosaad @kiliman @kentcdodds