-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring DataFunctionArgs
to LoaderFunctionArgs
and ActionFunctionArgs
#573
Comments
This will need to be addressed before Client Data comes to the Epic Stack, and since it's in unstable pre-release now I think it'd be a good time remix-run/remix#7634 (comment) Regarding handleError, I think we can actually delete it? It doesn't appear to be used https://github.com/search?q=repo%3Aepicweb-dev%2Fepic-stack%20handleError&type=code |
I'm really bummed about this decision by Remix, but whatever it's fine.
Anyone can feel free to make this change. PRs welcome. |
Ah makes sense, then @diegotc86 as documented there you can use the type |
Hi Kent,
I've noticed that The Epic Stack is utilizing
DataFunctionArgs
for the loaders and actions arguments, while the Remix documentation now advises usingLoaderFunctionArgs
andActionFunctionArgs
. If you think updating this would be beneficial, I'd be happy to assist.The action plan involves identifying all instances where
DataFunctionArgs
is used, replacing it with the appropriate type, and updating the imports as needed.P.S.: I've already located these instances. My only uncertainty is regarding the file
entry.server.ts
, whereDataFunctionArgs
is employed to type thehandleError
function. I believeLoaderFunctionArgs
would be a suitable replacement here.The text was updated successfully, but these errors were encountered: