chore: Build Cleanup #1451
chore: Build Cleanup #1451
Conversation
Removed multi-step usage in favor of faster builds without additional setup Removed scheduled jobs to match current release processes
WalkthroughThe pull request modifies two GitHub Actions workflow files to streamline the build process. In Changes
Sequence DiagramsequenceDiagram
participant User
participant GitHub Actions
participant Build System
User->>GitHub Actions: Trigger workflow
GitHub Actions->>Build System: Select platform (all/ios/android)
alt Platform is all
Build System->>Build System: Build iOS
Build System->>Build System: Build Android
else Platform is iOS
Build System->>Build System: Build iOS only
else Platform is Android
Build System->>Build System: Build Android only
end
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/build-internal.yml (1)
89-94: Consider consolidating platform checksWhile the platform-specific conditions work correctly, the implementation could be more DRY and informative.
Consider consolidating the platform checks into a shell function:
+ check_platform() { + local current_platform=$1 + local skip_platform=$2 + if [ "${{ github.event.inputs.platform || 'all' }}" == "$skip_platform" ]; then + echo "🚫 Skipping $current_platform build (platform set to $skip_platform)" + return 1 + fi + echo "🚀 Proceeding with $current_platform build" + return 0 + } + - # Check if platform is android, if so return success without building - if [ "${{ github.event.inputs.platform || 'all' }}" == "android" ]; then - echo "Skipping iOS build for Android" - exit 0 - fi + if ! check_platform "iOS" "android"; then + exit 0 + fi - # Check if platform is ios, if so return success without building - if [ "${{ github.event.inputs.platform || 'all' }}" == "ios" ]; then - echo "Skipping Android build for iOS" - exit 0 - fi + if ! check_platform "Android" "ios"; then + exit 0 + fiAlso applies to: 103-107
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/build-app-release.yml(1 hunks).github/workflows/build-internal.yml(2 hunks)
✅ Files skipped from review due to trivial changes (1)
- .github/workflows/build-app-release.yml
🔇 Additional comments (3)
.github/workflows/build-internal.yml (3)
20-28: Well-structured platform selection implementation!The new
platforminput parameter is well-designed with clear options and a sensible default value, allowing for flexible build targeting.
31-31: Effective job consolidation!The consolidation of build jobs into a single
build-with-easjob streamlines the workflow while maintaining all necessary functionality.
109-113: Verify build status handlingThe use of
--no-waitflag means the workflow won't track build status. This could lead to:
- Missed build failures
- No way to automatically retry failed builds
- Incomplete status reporting in GitHub
Consider implementing a build status check or removing the
--no-waitflag if build status tracking is important.You could add a status check step:
Removed multi-step usage in favor of faster builds without additional setup Removed scheduled jobs to match current release processes
Summary by CodeRabbit