Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: EAS Node Versions #1435

Merged
merged 4 commits into from
Dec 23, 2024
Merged

fix: EAS Node Versions #1435

merged 4 commits into from
Dec 23, 2024

Conversation

alexrisch
Copy link
Collaborator

@alexrisch alexrisch commented Dec 22, 2024

Summary by CodeRabbit

  • Chores
    • Updated Node.js version from 20.15.1 to 20.18.0 in development and production environments.
  • New Features
    • Incremented the iOS build number from 50 to 52.
    • Updated the Android version code from 249 to 251.
  • Bug Fixes
    • Removed the OpenSSL-Universal pod dependency from the iOS project.

@alexrisch alexrisch requested a review from a team as a code owner December 22, 2024 23:10
Copy link
Contributor

coderabbitai bot commented Dec 22, 2024

Walkthrough

The pull request involves updating the Node.js version in the eas.json configuration file. The Node.js version is upgraded from 20.15.1 to 20.18.0 in both the development and production sections. Additionally, the app.json file has been modified to increment the buildNumber for iOS from "50" to "52" and the versionCode for Android from 249 to 251. Furthermore, the Podfile has been updated to remove the dependency on "OpenSSL-Universal" version "1.1.2200".

Changes

File Change Summary
eas.json Updated Node.js version from 20.15.1 to 20.18.0 in development and production sections.
app.json Incremented buildNumber from "50" to "52" for iOS and versionCode from 249 to 251 for Android.
ios/Podfile Removed pod dependency for "OpenSSL-Universal" version "1.1.2200".

Possibly related PRs

  • fix: EAS Build Fixes #1099: The changes in eas.json regarding the Node.js version updates are relevant to the build process enhancements made in this PR, which also involves modifications to build configurations.
  • fix: eas build failed after changing ruby versions #1428: This PR includes changes to the eas.json, specifically related to build configurations, which may intersect with the updates made in the main PR regarding the Node.js version.

Suggested reviewers

  • thierryskoda

Poem

🐰 A Node.js upgrade, hop hop hooray!
From version old to new today
Twenty-point-eighteen now takes flight
Builds and deploys with rabbit might
Smooth as carrots, swift and bright! 🚀


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0813e04 and f18371c.

⛔ Files ignored due to path filters (1)
  • ios/Podfile.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • ios/Podfile (0 hunks)
💤 Files with no reviewable changes (1)
  • ios/Podfile

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Comment on lines +5 to +8
"buildNumber": "52"
},
"android": {
"versionCode": 249
"versionCode": 251
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version increments appear to be off by one from what's described in the PR summary. The PR indicates iOS buildNumber should be "51" and Android versionCode should be "250", but they're set to "52" and "251" respectively in the code changes.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

@alexrisch alexrisch merged commit 187d108 into release/3.0.0 Dec 23, 2024
5 checks passed
@alexrisch alexrisch deleted the ar/fix-eas-node-versions branch December 23, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants