-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new projection operators #34
Conversation
A small PR with minimum modification and clean commits. The one we like the most. I moved the paramter |
@@ -51,8 +51,10 @@ def assert_equivalent(param1, param2): | |||
assert_equivalent({'y': 3.2}, {'y': lambda: 3.2}) | |||
assert_equivalent({'A': None}, {'A': np.identity(3)}) | |||
A = np.array([[-4, 2, 5], [1, 3, -7], [2, -1, 0]]) | |||
pinvA = np.linalg.pinv(A) | |||
assert_equivalent({'A': A}, {'A': A, 'At': A.T}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I need to add the pinvA matrix because the proj_lineq
cannot compute it A is given as an operator. The automatic computation only works if A is a numpy array.
@mdeff PR ready to be reviewed. |
Thanks! Looks good to me apart from the small comments above. (I simplified the |
@mdeff Can I merge? |
|
Yes, it can be seen as a special case. If |
Where would you put the information? In the |
Great! Yep, in the |
Actually, a better way is to have
in
in |
All good. Thanks! |
Thank you for the good and efficient review process |
New features
proj_spsd
: projection of a matrix on the symmetric positive semi definite coneproj_lineq
: linear equality projection operator