GCP: Support resumable download and custom buffering size in pipe cli #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resumable downloading of the google storage blobs resolves connection reset issue and custom buffering increases an overall download performance. Both changes are described in details in the corresponding issue: #435.
mzueva
approved these changes
Jul 2, 2019
evgeniimv
pushed a commit
to evgeniimv/cloud-pipeline
that referenced
this pull request
Oct 14, 2019
…epam#475) * Add resumable downloads and custom buffering size for GCP blobs. Resumable downloading of the google storage blobs resolves connection reset issue and custom buffering increases an overall download performance. Both changes are described in details in the corresponding issue: epam#435. * Add checksum validation for GCP resumable downloads * Fix and refactor google storage downloading classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #435.
Add support for resumable blob downloads along with custom buffering size in pipe cli for Google cloud storages. See original issue for more information on the matter.
From now on blobs downloading from the Google cloud storage is resumable. It basically means that if any low-level connection error happens the interrupted download operation will be resumed from the current position.
Buffering size for downloading output files has been increased from the system defaults (usually
8192 B) up to1 MB.Two additional environment variables were added. Both of them can be used to override default pipe cli configurations:
CP_CLI_DOWNLOAD_BUFFERING_SIZE- buffering size for file system flushing. Defaults to1 MB.CP_CLI_RESUMABLE_DOWNLOAD_ATTEMPTS- maximum number of download sequential resumes before failing. Defaults to5attempts.Performance benchmarks
Instance type:
n1-standard-32Instance disk:
500 GBInstance and storage region:
europe-west1Download
Upload