Use custom download chunk size and increase download resume attempts #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use buffering size as download chunk size in order to improve overall google storage blobs download performance. Also increase default download resume attempts to bypass the connection reset issue described in #435 for most of the possible cases.
mzueva
approved these changes
Jul 2, 2019
evgeniimv
pushed a commit
to evgeniimv/cloud-pipeline
that referenced
this pull request
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #435 and is intented to improve google storage blobs performance along with #475.
Pull request makes buffering size to be used as download chunk size in order to improve overall google storage blobs download performance.
It was seen that download chunk size increase leads to a higher risk of connection reset. This is way the default download resume attempts were increased from
5up to100to cover most of the possible cases.Performance benchmarks
Instance type:
n1-standard-32Instance disk:
500 GBInstance and storage region:
europe-west1Download