[Fix] Ensure recursive calls to displayNameOfNode uses the adapter's version of the method #2482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eOfNode` uses the adapter's version of the method Fixes enzymejs#2481
mejackreed
commented
Dec 7, 2020
| @@ -886,13 +887,13 @@ class ReactSixteenAdapter extends EnzymeAdapter { | |||
| case ContextProvider || NaN: return 'ContextProvider'; | |||
| case Memo || NaN: { | |||
| const nodeName = displayNameOfNode(node); | |||
There was a problem hiding this comment.
One thing that wasn't clear to me was when/why we should use the adapter here or not.
There was a problem hiding this comment.
i think if we did, it would be an infinite loop.
2 tasks
Codecov Report
@@ Coverage Diff @@
## master #2482 +/- ##
=======================================
Coverage 96.04% 96.05%
=======================================
Files 49 49
Lines 3924 3925 +1
Branches 1102 1102
=======================================
+ Hits 3769 3770 +1
Misses 155 155
Continue to review full report at Codecov.
|
ljharb
approved these changes
Dec 7, 2020
| @@ -886,13 +887,13 @@ class ReactSixteenAdapter extends EnzymeAdapter { | |||
| case ContextProvider || NaN: return 'ContextProvider'; | |||
| case Memo || NaN: { | |||
| const nodeName = displayNameOfNode(node); | |||
There was a problem hiding this comment.
i think if we did, it would be an infinite loop.
ljharb
changed the title
this version of the function
ljharb
added a commit
that referenced
this pull request
Jan 20, 2021
- [fix] `.setContext()`: calls cWRP (#2476) - [fix] Ensure recursive calls to `displayNameOfNode` uses the adapter's version of the method (#2482) - [deps] update `object.assign`, `object.values`, `enzyme-adapter-utils` - [dev deps] update `eslint`, `eslint-config-airbnb`, `eslint-config-airbnb-base`, `eslint-plugin-import`, `eslint-plugin-jsx-a11y`, `eslint-plugin-react`, `eslint-plugin-react-hooks`, `babel-plugin-add-module-exports`, `@babel/cli`, `@babel/core`, `@babel/node`, `@babel/register`, `babel-loader`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2481
This is my first contribution to enzyme so happy to update/modify this PR as needed.