Fix: setContext doesn't trigger componentWillReceiveProps #2476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ljharb Here are the sandboxes React 0.14 Sandbox I will continue looking at the issue |
Codecov Report
@@ Coverage Diff @@
## master #2476 +/- ##
==========================================
+ Coverage 96.05% 96.13% +0.07%
==========================================
Files 49 49
Lines 3925 4006 +81
Branches 1102 1123 +21
==========================================
+ Hits 3770 3851 +81
Misses 155 155
Continue to review full report at Codecov.
|
ljharb
approved these changes
Dec 10, 2020
Comment on lines
+26
to
27
| spyMethod, | ||
| } from 'enzyme-adapter-utils'; |
There was a problem hiding this comment.
I ended up adding spyMethod/spyProperty to enzyme-adapter-utils, so that the adapters didn't have to suddenly start requiring enzyme v3.4.0.
ljharb
added a commit
that referenced
this pull request
Jan 20, 2021
- [fix] add missing `enzyme-shallow-equal` (#2476) - [meta] babel: set `transformRuntime` to false - [deps] update `object.assign`, `object.values`, `react-is`, `enzyme-adapter-utils` - [dev deps] update `eslint`, `eslint-config-airbnb`, `eslint-config-airbnb-base`, `eslint-plugin-import`, `eslint-plugin-jsx-a11y`, `eslint-plugin-react`, `eslint-plugin-react-hooks`, `babel-plugin-add-module-exports`, `@babel/cli`, `@babel/core`, `@babel/node`, `@babel/register`, `babel-loader`
ljharb
added a commit
that referenced
this pull request
Jan 20, 2021
- [fix] `.setContext()`: calls cWRP (#2476) - [deps] update `object.assign`, `object.values`, `react-is`, `enzyme-adapter-utils` - [dev deps] update `eslint`, `eslint-config-airbnb`, `eslint-config-airbnb-base`, `eslint-plugin-import`, `eslint-plugin-jsx-a11y`, `eslint-plugin-react`, `eslint-plugin-react-hooks`, `babel-plugin-add-module-exports`, `@babel/cli`, `@babel/core`, `@babel/node`, `@babel/register`, `babel-loader`
ljharb
added a commit
that referenced
this pull request
Jan 20, 2021
- [fix] `.setContext()`: calls cWRP (#2476) - [deps] update `object.assign`, `object.values`, `enzyme-adapter-utils` - [dev deps] update `eslint`, `eslint-config-airbnb`, `eslint-config-airbnb-base`, `eslint-plugin-import`, `eslint-plugin-jsx-a11y`, `eslint-plugin-react`, `eslint-plugin-react-hooks`, `babel-plugin-add-module-exports`, `@babel/cli`, `@babel/core`, `@babel/node`, `@babel/register`, `babel-loader`
ljharb
added a commit
that referenced
this pull request
Jan 20, 2021
- [fix] `.setContext()`: calls cWRP (#2476) - [fix] Ensure recursive calls to `displayNameOfNode` uses the adapter's version of the method (#2482) - [deps] update `object.assign`, `object.values`, `enzyme-adapter-utils` - [dev deps] update `eslint`, `eslint-config-airbnb`, `eslint-config-airbnb-base`, `eslint-plugin-import`, `eslint-plugin-jsx-a11y`, `eslint-plugin-react`, `eslint-plugin-react-hooks`, `babel-plugin-add-module-exports`, `@babel/cli`, `@babel/core`, `@babel/node`, `@babel/register`, `babel-loader`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2258
Below are two code sandboxes that show the bug exists, i added enzyme to the sandbox when you run the tests sandbox 2 doesn't call the method while sandbox 1 does.