docs: updated the developer guide #5347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anu-Ra-g <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5347 +/- ##
==========================================
+ Coverage 64.95% 64.97% +0.02%
==========================================
Files 213 213
Lines 33474 33474
==========================================
+ Hits 21742 21750 +8
+ Misses 10402 10396 -6
+ Partials 1330 1328 -2 ☔ View full report in Codecov by Sentry. |
zirain
previously approved these changes
Feb 25, 2025
arkodg
reviewed
Feb 25, 2025
| ### Raising a PR | ||
|
|
||
| * Run `make generate` and push the generated files along with your commit, if your PR contains any API changes (`/api`) or you've added some unit tests or you've updated the modules used in the project. | ||
|
|
There was a problem hiding this comment.
can we also add a line here on make testdata - which generates output testdata
There was a problem hiding this comment.
It's already present in the testing section. Should I add it here also?
Signed-off-by: Anu-Ra-g <[email protected]>
|
can you also add a note in https://github.com/envoyproxy/gateway/blob/main/.github/PULL_REQUEST_TEMPLATE.md that shows up as a comment, mentioning to go through https://gateway.envoyproxy.io/contributions/develop/#raising-a-pr |
Signed-off-by: Anu-Ra-g <[email protected]>
|
@arkodg I've made the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Documentation changes
What this PR does / why we need it:
This contains the steps to perform when raising a PR in the repository.
Which issue(s) this PR fixes:
Fixes #5346
Release Notes: No