Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updated docs for cert-manager installation #5328

Merged
merged 3 commits into from
Feb 25, 2025

Conversation

Anu-Ra-g
Copy link
Contributor

What type of PR is this?
Documentation change for the cert-manager installation using helm

What this PR does / why we need it:
This PR contains the updated helm installation docs for cert-manager and other changes.

Which issue(s) this PR fixes:

Fixes #4781

Release Notes: No

@Anu-Ra-g Anu-Ra-g requested a review from a team as a code owner February 22, 2025 08:08
Copy link

codecov bot commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.94%. Comparing base (f8c0b32) to head (700f62f).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5328      +/-   ##
==========================================
- Coverage   64.98%   64.94%   -0.04%     
==========================================
  Files         213      213              
  Lines       33474    33474              
==========================================
- Hits        21752    21740      -12     
- Misses      10396    10403       +7     
- Partials     1326     1331       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zirain
Copy link
Member

zirain commented Feb 22, 2025

/retest


```console
$ helm repo add jetstack https://charts.jetstack.io
$ helm upgrade --install --create-namespace --namespace cert-manager --set installCRDs=true --set featureGates=ExperimentalGatewayAPISupport=true cert-manager jetstack/cert-manager
$ helm upgrade \
--install cert-manager jetstack/cert-manager \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you specify exactly which version to use?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zirain I've updated the version to 1.17

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !
do the rest of the steps still work ?

@Anu-Ra-g
Copy link
Contributor Author

@arkodg Just tested it again,
image

@arkodg
Copy link
Contributor

arkodg commented Feb 25, 2025

Thanks @Anu-Ra-g, I was referring to the rest of the commands on the page

@arkodg arkodg merged commit 37a68f7 into envoyproxy:main Feb 25, 2025
28 checks passed
@arkodg
Copy link
Contributor

arkodg commented Feb 25, 2025

Merging this, since it meant to fix the specific issue, would be great to revisit the other commands on this doc as well

@Anu-Ra-g
Copy link
Contributor Author

Anu-Ra-g commented Feb 25, 2025

I'll check it again and let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Fix cert-manager Docs helm install
3 participants