Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set mgr to interface #530

Merged
merged 1 commit into from
Oct 14, 2022
Merged

feat: set mgr to interface #530

merged 1 commit into from
Oct 14, 2022

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Oct 10, 2022

Resolve: #182

Since this is a backlog issue, I will work on this after releasing v0.2.0.

Signed-off-by: bitliu [email protected]

@Xunzhuo Xunzhuo force-pushed the feat-mgr branch 2 times, most recently from 08d17dc to a5f47c7 Compare October 10, 2022 03:11
@codecov-commenter
Copy link

Codecov Report

Merging #530 (468db87) into main (b8f234b) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #530      +/-   ##
==========================================
- Coverage   62.72%   62.61%   -0.12%     
==========================================
  Files          42       42              
  Lines        4496     4496              
==========================================
- Hits         2820     2815       -5     
- Misses       1532     1536       +4     
- Partials      144      145       +1     
Impacted Files Coverage Δ
internal/infrastructure/kubernetes/infra.go 50.00% <100.00%> (ø)
internal/provider/kubernetes/gatewayclass.go 67.39% <0.00%> (-3.63%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Xunzhuo Xunzhuo marked this pull request as ready for review October 10, 2022 05:28
@Xunzhuo Xunzhuo requested a review from a team as a code owner October 10, 2022 05:28
@danehans danehans added the area/infra-mgr Issues related to the provisioner used for provisioning the managed Envoy Proxy fleet. label Oct 10, 2022
@danehans danehans added this to the 0.3.0-rc.1 milestone Oct 10, 2022
@LukeShu
Copy link
Contributor

LukeShu commented Oct 11, 2022

Looks OK to me, but I know that @danehans was hesitant to create an interface until we had a second provider to have an idea of what things might need to be different between providers.

@Xunzhuo
Copy link
Member Author

Xunzhuo commented Oct 12, 2022

Thanks for this comment @LukeShu, yes, so this can wait until we got another provider, and we can do better abstraction.

@arkodg
Copy link
Contributor

arkodg commented Oct 13, 2022

should be fine to get this in, and iterate, thanks for adding this @Xunzhuo

@danehans danehans merged commit 61f0999 into envoyproxy:main Oct 14, 2022
danehans pushed a commit to danehans/gateway that referenced this pull request Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra-mgr Issues related to the provisioner used for provisioning the managed Envoy Proxy fleet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert Manager Struct to Interface
5 participants