-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set mgr to interface #530
Conversation
08d17dc
to
a5f47c7
Compare
Signed-off-by: bitliu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #530 +/- ##
==========================================
- Coverage 62.72% 62.61% -0.12%
==========================================
Files 42 42
Lines 4496 4496
==========================================
- Hits 2820 2815 -5
- Misses 1532 1536 +4
- Partials 144 145 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Looks OK to me, but I know that @danehans was hesitant to create an |
Thanks for this comment @LukeShu, yes, so this can wait until we got another provider, and we can do better abstraction. |
should be fine to get this in, and iterate, thanks for adding this @Xunzhuo |
Signed-off-by: bitliu <[email protected]> Signed-off-by: bitliu <[email protected]>
Resolve: #182
Since this is a backlog issue, I will work on this after releasing v0.2.0.
Signed-off-by: bitliu [email protected]