Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Manager Struct to Interface #182

Closed
danehans opened this issue Jul 29, 2022 · 0 comments · Fixed by #530
Closed

Convert Manager Struct to Interface #182

danehans opened this issue Jul 29, 2022 · 0 comments · Fixed by #530
Labels
area/infra-mgr Issues related to the provisioner used for provisioning the managed Envoy Proxy fleet. help wanted Extra attention is needed
Milestone
Backlog

Comments

@danehans
Copy link
Contributor

danehans commented Jul 29, 2022 •
edited
Loading

Convert the infra Manager struct into an interface. This should be done when additional infra providers are supported. Have all providers implement the interface.

xref: #178 (comment)
@danehans danehans added the area/infra-mgr Issues related to the provisioner used for provisioning the managed Envoy Proxy fleet. label Jul 29, 2022
@danehans danehans added this to the Backlog milestone Jul 29, 2022
@danehans danehans added the help wanted Extra attention is needed label Jul 29, 2022
@danehans danehans mentioned this issue Jul 29, 2022
Merged
@Xunzhuo Xunzhuo mentioned this issue Oct 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/infra-mgr Issues related to the provisioner used for provisioning the managed Envoy Proxy fleet. help wanted Extra attention is needed
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

feat: set mgr to interface Xunzhuo/gateway
1 participant
@danehans