Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename control-plane metrics #3727

Merged
merged 8 commits into from
Jul 3, 2024

fix lint

6e25023
Select commit
Loading
Failed to load commit list.
Merged

refactor: rename control-plane metrics #3727

fix lint
6e25023
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 2, 2024 in 0s

68.76% (target 60.00%)

View this Pull Request on Codecov

68.76% (target 60.00%)

Details

Codecov Report

Attention: Patch coverage is 34.24658% with 48 lines in your changes missing coverage. Please review.

Project coverage is 68.76%. Comparing base (ec9945a) to head (6e25023).

Files Patch % Lines
...ternal/infrastructure/kubernetes/infra_resource.go 34.28% 23 Missing ⚠️
internal/metrics/otel_metric_counter.go 0.00% 15 Missing ⚠️
internal/xds/cache/snapshotcache.go 0.00% 7 Missing ⚠️
internal/provider/kubernetes/status_updater.go 50.00% 2 Missing ⚠️
internal/message/watchutil.go 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3727      +/-   ##
==========================================
- Coverage   68.81%   68.76%   -0.05%     
==========================================
  Files         175      175              
  Lines       21524    21523       -1     
==========================================
- Hits        14811    14800      -11     
- Misses       5636     5647      +11     
+ Partials     1077     1076       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov