-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rename control-plane metrics #3727
Conversation
Signed-off-by: shawnh2 <[email protected]>
Signed-off-by: shawnh2 <[email protected]>
Signed-off-by: shawnh2 <[email protected]>
Signed-off-by: shawnh2 <[email protected]>
Signed-off-by: shawnh2 <[email protected]>
Signed-off-by: shawnh2 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3727 +/- ##
==========================================
- Coverage 68.81% 68.76% -0.05%
==========================================
Files 175 175
Lines 21524 21523 -1
==========================================
- Hits 14811 14800 -11
- Misses 5636 5647 +11
+ Partials 1077 1076 -1 ☔ View full report in Codecov by Sentry. |
will update grafana dashboard in a follow-up PR |
Signed-off-by: shawnh2 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with the general good approach, but should fix CI before merging
/retest |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3684