Fix assorted breakages and Windows compilation changes #9966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uild This fix to foreign_cc BoringSSL build addresses the fact that its own bazel build doesn't respect Envoy's choice to build a static library. The patch deserve further additions and adjustment, but resolves #8754 which could not be reopened due to my force push. It was intended for PR9915 but missed the boat. Signed-off-by: William A Rowe Jr <[email protected]> Signed-off-by: Yechiel Kalmenson <[email protected]> Signed-off-by: Sunjay Bhatia <[email protected]> Co-authored-by: William A Rowe Jr <[email protected]> Co-authored-by: Yechiel Kalmenson <[email protected]> Co-authored-by: Sunjay Bhatia <[email protected]>
This picks up a bugfix from Ylavic which avoids using Win32 MSVC warning pragmas in the case of clang-cl compilation. Unfortunately clang-cl presents itself with an _MSC_VER preprocessor built-in macro, which is very misleading. Note that compiling with MSVC's own distribution of clang-cl is not corrected, but it seems very unlikely that will ever happen in the future (32 not 64 bit compiler.) Co-authored-by: William A Rowe Jr <[email protected]> Co-authored-by: Sunjay Bhatia <[email protected]> Signed-off-by: William A Rowe Jr <[email protected]> Signed-off-by: Sunjay Bhatia <[email protected]>
Signed-off-by: William A Rowe Jr <[email protected]>
Support platform process scope requirements, such as WSAStartup behavior for Windows. Signed-off-by: William A Rowe Jr <[email protected]>
This creates a space for source/common/api/win32 and seperates changes to posix from the commit which here relocates the files Signed-off-by: Sunjay Bhatia <[email protected]> Signed-off-by: William A Rowe Jr <[email protected]>
Signed-off-by: Sunjay Bhatia <[email protected]> Signed-off-by: William A Rowe Jr <[email protected]>
Otherwise compiling the mocks w/ gcc on Linux fails due to `-Werror=overloaded-virtual` being treated as an error Signed-off-by: William A Rowe Jr <[email protected]> Co-authored-by: Sunjay Bhatia <[email protected]>
APC is a common acronym we will likely use more for Windows Signed-off-by: William A Rowe Jr <[email protected]> Co-authored-by: Sunjay Bhatia <[email protected]>
mattklein123
reviewed
Feb 7, 2020
source/common/api/BUILD
Outdated
Comment on lines
45
to
46
| ] + select({ | ||
| "//conditions:default": [], |
There was a problem hiding this comment.
This can be deleted, right?
There was a problem hiding this comment.
We'd prefer to leave it (fill-in-the-gap adds windows specifics there in a upcoming patch, if that's alright.) Trying to keep as many changes in the upcoming commits to be line-oriented diffs.
There was a problem hiding this comment.
we found that we didn't need the subsequent changes in the later commit for Windows, so we will remove this bit
Signed-off-by: Sunjay Bhatia <[email protected]> Co-authored-by: William A Rowe Jr <[email protected]> Co-authored-by: Sunjay Bhatia <[email protected]>
mattklein123
approved these changes
Feb 7, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Risk Level: Low
Testing: Local on gcc Linux, msvc Windows
Docs Changes: N/A
Release Notes: N/A
Fixes #8351