Inhibit attempted copying of missing crypto.if.lib for static win32 build #8754
Conversation
…uild Signed-off-by: William A Rowe Jr <[email protected]> Signed-off-by: Yechiel Kalmenson <[email protected]>
|
@lizan per discussion elsewhere, could you look at this? |
|
Can you add a line |
This tests compilation of several components in the Windows CI which were impacted by the recent foreign_cc cmake build changes and proposed fixes to boringssl's internal bazel build schema. Signed-off-by: William A Rowe Jr <[email protected]> Signed-off-by: Yechiel Kalmenson <[email protected]> Signed-off-by: William A Rowe Jr <[email protected]>
|
That's very sensible. We've added other foreign_cc components which are building correctly, and can begin adding other bazel-based dependencies as well as we've reviewed them. This resolves all the issues of accepting this patch? |
Signed-off-by: William A Rowe Jr <[email protected]> Signed-off-by: Yechiel Kalmenson <[email protected]> Signed-off-by: William A Rowe Jr <[email protected]>
|
We've reconfirmed this subset builds correctly on Windows, patched against master. We are likely missing one or more of the msys2 (bash), python, jdk8 or even perhaps go language tooling? |
Signed-off-by: Yechiel Kalmenson <[email protected]> Signed-off-by: William A Rowe Jr <[email protected]>
|
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
stale
bot
added
the
stale
|
This pull request has been automatically closed because it has not had activity in the last 14 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
/wait I don't believe we want this patch as-is because on OS/X I understand we are building all objects dynamic. |
|
Since this was 3 mos stale, I've rebased and force-pushed. @lizan could you have a look? I guess I misunderstood that everywhere we consuming boringssl we expect it to be simply a static lib dependency. |
|
@wrowe can you open a new PR based on this? Since you force-pushed GH doesn't allow me to re-open. |
|
Good to learn that, thanks. Will do so over the weekend. |
See discussion at;
https://github.com/envoyproxy/envoy/pull/8280/files/b84fc6bc69677d00bd3f8ddfcbd23efee0e44893#r332278621
This deserves attention by the boringssl bazel build maintainers, solving for short-term.
Signed-off-by: William A Rowe Jr [email protected]
Signed-off-by: Yechiel Kalmenson [email protected]
Description:
Risk Level: Low
Testing: Local on Windows
Docs Changes: n/a
Release Notes: n/a