Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orca: fix the delimiter of the native http parser #37724

Merged
merged 5 commits into from
Dec 19, 2024

Merge branch 'main' of https://github.com/envoyproxy/envoy into dev-f…

d27eeef
Select commit
Loading
Failed to load commit list.
Merged

orca: fix the delimiter of the native http parser #37724

Merge branch 'main' of https://github.com/envoyproxy/envoy into dev-f…
d27eeef
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/Android tests skipped Dec 19, 2024 in 0s

Check was skipped

This check was not triggered in this CI run

Details

Request (pr/37724/main@d27eeef)

wbpcode @wbpcode d27eeef #37724 merge main@99bbfe8

orca: fix the delimiter of the native http parser

Commit Message: orca: fix the delimiter of the native http parser
Additional Description:

This should also be cherry-pick to 1.32 to fix this problem.

The previous ORCA parser will use : as the delimiter of key/value pair in the native HTTP report. This is wrong
based on the design document. The correct delimiter should be =. This change fixes the delimiter to =.
See #6614 and related documents for more details.

https://docs.google.com/document/d/1NSnK3346BkBo1JUU3I9I5NYYnaJZQPt8_Z_XCBCI3uA/edit?tab=t.0

Native HTTP header encoding.  Similar to the JSON dictionary format, we will define Endpoint-Load-Metrics as having 
key=value format and use standard HTTP header encoding to either send the metrics as a sequence of HTTP headers or 
as a single header with [comma separated](https://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.2) key-value 
pairs. E.g.  endpoint-load-metrics: TEXT cpu=0.3,mem=0.8,foo_bytes=123.

Risk Level: n/a.
Testing: n/a.
Docs Changes: n/a.
Release Notes: added.

Environment

Request variables

Key Value
ref ec6a45f
sha d27eeef
pr 37724
base-sha 99bbfe8
actor wbpcode @wbpcode
message orca: fix the delimiter of the native http parser...
started 1734575975.054998
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:d2be0c198feda0c607fa33209da01bf737ef373f
mobile envoyproxy/envoy-build-ubuntu:mobile-d2be0c198feda0c607fa33209da01bf737ef373f
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 33
patch 0
dev true